From: "Nuno Sá" <nuno.sa@analog.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Marcelo Schmitt <marcelo.schmitt@analog.com>,
Joshua Crofts <joshua.crofts1@gmail.com>,
Radu Sabau <radu.sabau@analog.com>,
Janani Sunil <janani.sunil@analog.com>,
Salih Erim <salih.erim@amd.com>,
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>,
Jakub Szczudlo <jakubszczudlo40@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 0/4] iio: adc: ade9000: add support for ADE9039
Date: Tue, 13 Oct 2026 10:51:55 +0100 [thread overview]
Message-ID: <as3-vbbd2FKdMzP0@nsa> (raw)
In-Reply-To: <20261012111342.48040-1-antoniu.miclaus@analog.com>
On Mon, Oct 12, 2026 at 02:13:36PM +0300, Antoniu Miclaus wrote:
> Add support for the ADE9039, a polyphase energy monitoring device in the
> ADE9000 family. It is register compatible with the ADE9000 for every
> register the driver touches. The differences that matter here are:
>
> - full-scale codes match the ADE9078, not the ADE9000;
> - dip/swell detection and the digital integrator are both present;
> - there is no total reactive power: no AVAR at 0x211, no AVAROS at
> 0x010, only the fundamental AFVAR and AFVAROS;
> - maximum SPI clock is 10 MHz, as on the ADE9078.
>
> It is the first part needing dip/swell present together with total
> reactive power absent, which the channel-array macro could not express.
> Patch 1 adds a second selector argument for the reactive power entry; it
> is a no-op for the existing parts, with the preprocessed ade9000_channels
> and ade9078_channels tables byte identical before and after.
>
> The missing total reactive power channel is omitted rather than
> repointed at AFVAR, which would make in_power[0-2]_reactive_raw mean
> total power on the ADE9000 and fundamental power on the ADE9039 with no
> IIO modifier to tell them apart. The fundamental reactive energy
> channels are unaffected.
>
> Patch 4 also clears three stray characters left in the ade9000.rst
> introduction by the ADE9430 merge resolution. Happy to split that out.
>
> Antoniu Miclaus (4):
> iio: adc: ade9000: parameterise the reactive power channel
> dt-bindings: iio: adc: adi,ade9000: add adi,ade9039 compatible
> iio: adc: ade9000: add support for ADE9039
> docs: iio: ade9000: document ADE9039 support
>
> .../bindings/iio/adc/adi,ade9000.yaml | 29 ++++++++------
> Documentation/iio/ade9000.rst | 24 +++++++-----
> drivers/iio/adc/Kconfig | 1 +
> drivers/iio/adc/ade9000.c | 39 ++++++++++++++++---
> 4 files changed, 66 insertions(+), 27 deletions(-)
>
>
> base-commit: a22dc7ebb21a6bd4c8b63bc2c1dd46a24945aae7
> --
> 2.43.0
>
Don't love the power_reactive handling in terms of readability but
fine...
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
prev parent reply other threads:[~2026-10-13 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 11:13 Antoniu Miclaus
2026-10-12 11:13 ` [PATCH 1/4] iio: adc: ade9000: parameterise the reactive power channel Antoniu Miclaus
2026-10-12 13:51 ` Joshua Crofts
2026-10-12 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: adi,ade9000: add adi,ade9039 compatible Antoniu Miclaus
2026-10-12 13:46 ` Joshua Crofts
2026-10-12 18:59 ` Conor Dooley
2026-10-12 11:13 ` [PATCH 3/4] iio: adc: ade9000: add support for ADE9039 Antoniu Miclaus
2026-10-12 13:50 ` Joshua Crofts
2026-10-12 11:13 ` [PATCH 4/4] docs: iio: ade9000: document ADE9039 support Antoniu Miclaus
2026-10-12 13:49 ` Joshua Crofts
2026-10-13 9:51 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as3-vbbd2FKdMzP0@nsa \
--to=nuno.sa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jakubszczudlo40@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt@analog.com \
--cc=radu.sabau@analog.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®