From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD8823FA5CC; Tue, 13 Oct 2026 09:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791883110; cv=none; b=AG2Ik+wzi9fpY8BmUj7l8zSn0oiYLWLXQiTBFoAxzKhJDA9uVTsLporkJPxgRUJ/tISPM0emP2wrzaaiuw6Wj05rbvWAsYjJtVw2VxkwmXucSDcpUXwwgc7gQ5bkekS9D3CPH2d/n1Uap6PA5/KDV4UWdBzBhGVjsWTfj739OnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791883110; c=relaxed/simple; bh=EOkC7IxwRjX5sV7VTQMqZrlCovHAjCLACVvh+hdQqTQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hSW+9DuHJBS9Dl/yhFizQDb1ns7a/eDXFClhK5XuDo8SLK7Cr2F5nAAAnE1rEsGXdE+P4xTKt304p4i0zmWZfK3QTb/VIsobZR7On9u2bU+vbS/eTyuJ/or5LbWTNO0+p7URYjQgmuyL/D7yLHWOdv13bXOsYnR7SZhabw+lP1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=j1hjgoF9; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="j1hjgoF9" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F9E3169C; Tue, 13 Oct 2026 02:18:21 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 724B73F7B4; Tue, 13 Oct 2026 02:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1791883104; bh=EOkC7IxwRjX5sV7VTQMqZrlCovHAjCLACVvh+hdQqTQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j1hjgoF9HlQ/oP+4K7eHi4L+8h/Oz32n9SCYza9/O6FSh+/whx+zkwfXx/GApokxV 1yG0fCmEIYQCchZDyiqyqHeBzkJqZkj8TyuKKhsHKv8GILo4p7TAzJfji2JuIz2vFw DG2fxW3PkXrceMTJEiu02y79uPY3e4o/Au5Nb58g= Date: Tue, 13 Oct 2026 10:18:19 +0100 From: Yeoreum Yun To: Mike Rapoport Cc: Yeoreum Yun , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Shuah Khan , Jason Gunthorpe , Leon Romanovsky , Sarthak Sharma Subject: Re: [PATCH v5 2/3] kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro Message-ID: References: <20261009-fix_hpage_macro-v5-0-54378ae45add@arm.com> <20261009-fix_hpage_macro-v5-2-54378ae45add@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Mike, > Hi Yeoreum, > > On Fri, Oct 09, 2026 at 02:27:33AM +0100, Yeoreum Yun wrote: > > HPAGE_SIZE and HPAGE_SHIFT macro is written based on the 4KB PAGE_SIZE. > > When this macro is used in some test, test result would be strange in > > the system where PAGE_SIZE is more then 4KB. > > > > Here is the example with transhuge-stress test with 16KB PAGE_SIZE: > > > > transhuge-stress: allocate 61073 transhuge pages, using 122146 MiB virtual memory and 1908 MiB of ram > > 3.292 s/loop, 0.054 ms/page, 37106.002 MiB/s 2566 succeed, 58507 failed, 2566 different pages > > 0.591 s/loop, 0.010 ms/page, 206850.792 MiB/s 0 succeed, 61073 failed, 0 different pages > > 0.527 s/loop, 0.009 ms/page, 231895.107 MiB/s 0 succeed, 61073 failed, 0 different pages > > 0.527 s/loop, 0.009 ms/page, 231839.704 MiB/s 0 succeed, 61073 failed, 0 different pages > > 0.528 s/loop, 0.009 ms/page, 231544.782 MiB/s 0 succeed, 61073 failed, 0 different pages > > 0.528 s/loop, 0.009 ms/page, 231462.074 MiB/s 0 succeed, 61073 failed, 0 different pages > > 0.527 s/loop, 0.009 ms/page, 231770.300 MiB/s 0 succeed, 61073 failed, 0 different pages > > ... > > ok 1 Completed > > > > Remove the HPAGE_SIZE and HPAGE_SHIFT macro and introduce pmd_pshift() > > helper to get the HPAGE_SHIFT properly. For HPAGE_SIZE, use pre-existing > > helper, pmd_psize(). > > > > Also, run the KSM_MERGE_TIME_HUGE_PAGES test with a size of 512 MiB, > > which is the least common multiple of the PMD sizes for 4 KiB, 16 KiB, > > and 64 KiB base pages. Since allocate_transhuge() allocates mappings in > > PMD-sized units, the test may fail with the previous size of 100 MiB, > > which is not a multiple of the PMD size when the base page size is > > 16 KiB or 64 KiB. > > > > After this patch, output of transhuge-stress: > > > > transhuge-stress: allocate 3817 transhuge pages, using 122146 MiB virtual memory and 119 MiB of ram > > 2.558 s/loop, 0.670 ms/page, 47755.759 MiB/s 2585 succeed, 1232 failed, 2585 different pages > > 2.640 s/loop, 0.692 ms/page, 46268.432 MiB/s 2585 succeed, 1232 failed, 2585 different pages > > 2.635 s/loop, 0.690 ms/page, 46360.298 MiB/s 2585 succeed, 1232 failed, 2585 different pages > > 2.782 s/loop, 0.729 ms/page, 43899.795 MiB/s 2616 succeed, 1201 failed, 2616 different pages > > 2.692 s/loop, 0.705 ms/page, 45380.876 MiB/s 2627 succeed, 1190 failed, 2627 different pages > > 2.612 s/loop, 0.684 ms/page, 46765.812 MiB/s 2628 succeed, 1189 failed, 2628 different pages > > 2.683 s/loop, 0.703 ms/page, 45520.990 MiB/s 2630 succeed, 1187 failed, 2630 different pages > > 2.727 s/loop, 0.714 ms/page, 44789.321 MiB/s 2631 succeed, 1186 failed, 2631 different pages > > ... > > ok 1 Completed > > > > Suggested-by: Lorenzo Stoakes (ARM) > > Reviewed-by: Zi Yan > > Signed-off-by: Yeoreum Yun > > --- > > tools/testing/selftests/mm/guard-regions.c | 11 ++++++-- > > tools/testing/selftests/mm/ksm_tests.c | 16 ++++++----- > > tools/testing/selftests/mm/run_vmtests.sh | 4 +-- > > tools/testing/selftests/mm/transhuge-stress.c | 25 +++++++++++------- > > tools/testing/selftests/mm/vm_util.c | 38 +++++++++++++++++++++++---- > > tools/testing/selftests/mm/vm_util.h | 9 +++---- > > 6 files changed, 72 insertions(+), 31 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/guard-regions.c b/tools/testing/selftests/mm/guard-regions.c > > index f7d53ea3c2527..3052823b0eff6 100644 > > --- a/tools/testing/selftests/mm/guard-regions.c > > +++ b/tools/testing/selftests/mm/guard-regions.c > > @@ -2194,14 +2194,21 @@ TEST_F(guard_regions, pagemap_scan) > > TEST_F(guard_regions, collapse) > > { > > const unsigned long page_size = self->page_size; > > - const unsigned long size = 2 * HPAGE_SIZE; > > - const unsigned long num_pages = size / page_size; > > + const uint64_t hpage_size = pmd_psize(); > > + unsigned long size; > > + unsigned long num_pages; > > These can be declared in the same line, or at least follow reverse xmas > tree convention. > The xmas tree comment applies to other declarations you are changing where > it makes sense without additional changes. Okay. I'll change it. Thanks! -- Sincerely, Yeoreum Yun