From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C51B50129F; Tue, 13 Oct 2026 14:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.121.34.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791902251; cv=none; b=NjMrzsouwy2wZKnqq+d5WlGniUxYNKg/9FhxG++YXUXJs8Gm46W+DcMcbzhYMa2lnrdi+6Ui1KPC1haP72j0oD8wWb2I1RnmqXwYeJPLbWBKEBSN8Buk/G+IFHtMMrlODvSdhcr1xEfy8tkOYcChozH4+cZSTubqABGUwC9Nw58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791902251; c=relaxed/simple; bh=5jKPCpzP3ydgQqLnqgc6m8dhumkZpBBD4O7fxHqz170=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c+2yvPjwrrOJGDeOy5+7E6AcAqQEfDOPojfllLvOGxnYXgZYhSZSy1UPXFMWYtAtK2JqP1ul6JisMb9QbNDrfqG80rkbIAaWeb87GgK6oFlJFWd0fRN/ZPr3ugXSDKwAVWmn/Ke0AOtv9JGwBXKV3lcVMjFZ8vL45bKq6KVUQCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; arc=none smtp.client-ip=92.121.34.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id EC50A1A01A5; Tue, 13 Oct 2026 16:37:21 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C89A01A00E9; Tue, 13 Oct 2026 16:37:21 +0200 (CEST) Received: from lsv051416.swis.nl-cdc01.nxp.com (lsv051416.swis.nl-cdc01.nxp.com [10.168.48.122]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 516EE202DA; Tue, 13 Oct 2026 16:37:21 +0200 (CEST) Date: Tue, 13 Oct 2026 16:37:21 +0200 From: Jan Petrous To: Frank Li Cc: Ciprian Marian Costea , NXP S32 Linux Team , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ghennadi Procopciuc , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Magnus Damm , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Bogdan Hamciuc , Ionut Vicovan , Andrew Lunn , Heiner Kallweit , Russell King , Clark Wang , Philipp Zabel , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Vincent Guittot Subject: Re: [PATCH RFC v3 03/12] dt-bindings: PCI: nxp,s32g-pcie: Fix SerDes PHY phandle in example Message-ID: References: <20260919-s32g_serdes-v3-0-9d68868c1e89@oss.nxp.com> <20260919-s32g_serdes-v3-3-9d68868c1e89@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Oct 12, 2026 at 01:43:05PM -0500, Frank Li wrote: > On Sat, Sep 19, 2026 at 08:54:31AM +0200, Jan Petrous via B4 Relay wrote: > > [You don't often get email from devnull+jan.petrous.oss.nxp.com@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > From: "Jan Petrous (OSS)" > > > > The example references the SerDes PHY as > > > > phys = <&serdes0 PHY_TYPE_PCIE 0 0>; > > > > i.e. the SerDes node itself with three PHY cells. That does not match > > the SerDes binding: the per-lane child node is the generic PHY > > provider and carries '#phy-cells = <0>', while the SerDes node itself > > has no '#phy-cells' at all. > > > > Point the example at the PCIe lane child instead, which is also what > > the S32G3 board device trees use. The dt-bindings/phy/phy.h include is > > dropped along with the now-unused PHY_TYPE_PCIE constant. > > > > The schema itself is unchanged; 'phys: maxItems: 1' already describes > > the corrected form. > > > > Signed-off-by: Jan Petrous (OSS) > > --- > > Documentation/devicetree/bindings/pci/nxp,s32g-pcie.yaml | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/nxp,s32g-pcie.yaml b/Documentation/devicetree/bindings/pci/nxp,s32g-pcie.yaml > > index 66a050028278..29323e50bd8b 100644 > > --- a/Documentation/devicetree/bindings/pci/nxp,s32g-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/nxp,s32g-pcie.yaml > > @@ -82,7 +82,6 @@ unevaluatedProperties: false > > examples: > > - | > > #include > > - #include > > > > bus { > > #address-cells = <2>; > > @@ -124,7 +123,7 @@ examples: > > ranges; > > > > device_type = "pci"; > > - phys = <&serdes0 PHY_TYPE_PCIE 0 0>; > > + phys = <&serdes0_pcie0>; > > I don't think it fix somethings. The "serdes0" just a label, point to > provider, which is not neccsary that "#phy-cells" is 0. > > Examples just show need how many phys and don't care about phy provider's > arguments > The example validates either way, agreed. The three cells are the '#phy-cells = <3>' of the downstream nxp,s32cc-serdes binding, which was never posted upstream; patch 1 is the only SerDes binding for S32G and has no three-cell provider. I would rather have the example match it. The form depends on the outcome of your patch 1 comment, so I will keep this patch in sync with that. If you prefer the phys line untouched, I can drop it and keep only the ranges fix v4 adds here. BR. /Jan