From: Keith Busch <kbusch@kernel.org>
To: Keith Busch <kbusch@meta.com>
Cc: dinguyen@kernel.org, schuster.simon@siemens-energy.com,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
lftan@altera.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] nios2: fix __wsum type degradation in csum_fold()
Date: Tue, 13 Oct 2026 09:06:26 -0600 [thread overview]
Message-ID: <as5I8gmaWXr5OUgb@kbusch-mbp> (raw)
In-Reply-To: <20260922153416.730513-1-kbusch@meta.com>
On Tue, Sep 22, 2026 at 08:34:16AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> csum_fold() shifts a bitwise __wsum type, which sparse reports as
> "restricted __wsum degrades to integer". Sparse only checks the body of
> a static inline once something instantiates it, so this went unnoticed
> until a recent block layer change added the first csum_fold() caller to
> a file built on this architecture.
>
> Force cast to a __u32 for the shift, as the other architectures do.
Ping on this one?
next prev parent reply other threads:[~2026-10-13 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 15:34 Keith Busch
2026-10-13 15:06 ` Keith Busch [this message]
2026-10-13 23:45 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as5I8gmaWXr5OUgb@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dinguyen@kernel.org \
--cc=kbusch@meta.com \
--cc=lftan@altera.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=schuster.simon@siemens-energy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®