From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92ABE47C0E6 for ; Tue, 13 Oct 2026 15:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904541; cv=none; b=m4T6r/fvAMPAN7v5D7vfHyHy1a0InX2ylI0hiaKKLBmehxz0B3eBPwv5LqT9KGVo2rQc7J3swHlAggvRZoGkpKnwglwmFePSMNzbx2ZtxLP53c65oP0sRsfpqvBFKIzXsviw1lK0Y7kIUlkdxKOOP+37ORj4I0DyizSDIhUTE6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904541; c=relaxed/simple; bh=NapyJptIydBk5J98yC370DZ0xJWQKRaBbCy2B6XYHdA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dta/wP/sqRFIPE8U7ZaPElKjmHfNPtUhLunFD4zUdvjvB3CrbPqRLQeyzrniUB0UTKfLS+1Ns+A8OxNPtbNx/ExYKTiNFdDMDNUcNs4JlixxBpdCYj2CS3tdqOrsMGzNeGE1YX2drr8vpyZndFOYxQ+eofT2SIB0BdFgBHwMs3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dBR1jNe2; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dBR1jNe2" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2e901e114fdso8480415ad.2 for ; Tue, 13 Oct 2026 08:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904538; x=1792509338; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2rkGQo5r8xJBTb8dqMKiMW12xMK6T9au6oc+12YcxIA=; b=dBR1jNe2zWAjzp5Bc6vkfwkBFJT/e/xEeahREKd0JJot7RWYmlid9VLytpa/O3jrwW P5Ptck1EnD1e8U7lCGtukjez7EDLIMYgIVSGIfCbRg5zZe2bIeLv/0yrrfpgxzweip1s R0otIA3SH4LNMPXlLyxZwpZ/F3T85Ssk0Z/3V6Yo3ESx6iTitPmD7zfxRduALS11tctY jnNMq0SVZeOzUlal2D3yFrMeycUtMFX2h+/LR910q61QM97mZz5DeCK7fefFAI9fDhAJ zXF2aP7VzDt1z1GZrVbQkZKDyFsublEff2OzotGs8KhTDvcYAoGJoPCQ1tXyIqCrmhb3 Ju3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904538; x=1792509338; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2rkGQo5r8xJBTb8dqMKiMW12xMK6T9au6oc+12YcxIA=; b=YX5neb45Cv33nBPyqXQdjmRjIygalXvGPK3wsHWPA7WpyrUR6UhpNw+zYkMxCfOTHn sm0cyBBgLGCipZRS1aUTvk+edyLxUTG1rGcuqRend2UORFfRKwZRa7n4E3ctQXykS7N/ Ue8xRblxPtIQuYqBodtfencHJXBq5Y0Kq6ApDlkDgq72Y1H4wEAAOxNMbzS7FgbrMVIm ws826BUvo6vzjsBIzJPRB51b5vCPNYgXKL3uCxoirG7IYI03vG10zJTiAsOn+T2doQMS XyZH5Ur869j7675JSlrILM8yri3Cc6daNlWgGdoafo39/7W1oCmVdcRqh7KaPz6YWJs1 SVLQ== X-Forwarded-Encrypted: i=1; AKwUvBxPLg5Vc3JSux1YaZV1+xwTwyxDR1mBWr3zy7ss4IRKff2jzok+hTbu+ieS6295cIi5xeXXdULzAXs//C8=@vger.kernel.org X-Gm-Message-State: AFq9FYLHer+zBuN1ButW42ZGS20QYL1XNUu5nXak/yq7ELLeZ2unOdLQ c41ALMN2FQYXjFFi+HaKGFEOt5gtkW08Qa2VKg2HU2Fm3H47h/uc+jrK X-Gm-Gg: AYBFou3oSmHk/SWg1klrYdPtWYnpjvNdibYhvbvT6+wtKDQThV/j78HO1CM00RtTRx5 IEklSirCvVdylOYiJ+ji8iIU8bgJvEPgZzu060ssft+KDNLB5kuVS01O2Ne+DA7D0pWrJF0p4iT RsY5cMLfRFVFYePl7W9LPOdVPhl5eyYVEx9lzyyMIXpZ8eQmg7ouFKeZ+Y+8hxMpP/P2e/3x3nA 7d2rqW7qkfjWFEVkVPydDi++eOsegQCm9sGDA/YgEB+qREXJBuCQeMhcOaIsEn1hAdb3N6Ozb5W mV2qOBEa77FT+1U3qYqQsd+JrHTyYSIg9ITwdbU2WU6i414ueDRgInzIEtUbH/2rvbcNE81iCNI Lm+6Z54TksZB/rWJcHEU22nlNAYYHBBPl6YAbS5RihgMf9Q/7HTm7C9K6/a5mItlGlexSSkTCiV GT+bbc33I7tZV9GlaWPigjdrTYdI8iQ/NlmAcqXEuyAgtASEhqqwRmu/yTBscWxyBxL8QTEwGl1 Q== X-Received: by 2002:a17:902:f54f:b0:2e6:1a1:ef63 with SMTP id d9443c01a7336-2e842cdb1e7mr112815415ad.44.1791904537778; Tue, 13 Oct 2026 08:15:37 -0700 (PDT) Received: from localhost ([104.156.230.40]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8c4csm58698205ad.56.2026.10.13.08.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:15:37 -0700 (PDT) Date: Tue, 13 Oct 2026 23:15:21 +0800 From: Chang Yu To: Joshua Crofts Cc: Chang Yu , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Hao , "Jose A. Perez de Azpillaga" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] dt-bindings: iio: light: add as7343 Message-ID: References: <20261013115639.167433-1-marcus.yu.56@gmail.com> <20261013115639.167433-2-marcus.yu.56@gmail.com> <20261013143639.000017b9@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013143639.000017b9@gmail.com> On Tue, Oct 13, 2026 at 02:36:39PM +0200, Joshua Crofts wrote: > On Tue, 13 Oct 2026 19:56:38 +0800 > Chang Yu wrote: > > > Add binding for AMS AS7343 which is a 14-channel multi-spectral sensor > > with i2c address of 0x39. > > > > The GPIO pin is not described because the datasheet does not document > > how to use it for hardware synchronization at all. The GPIO register > > also has no mode-select bit to isolate the pin from the chip's > > internal control logic. Exposing it as a generic GPIO could result > > in kernel writes being overwritten by internal logic. > > > > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf > > Signed-off-by: Chang Yu > > --- > > Changes in v6: > > - Add a ref to leds/common.yaml for the LDR pin. > > > > Changes in v5: > > - Remove the GPIO pin. > > > > Changes in v4: > > - Fix led-max-microamp property name. > > > > Changes in v3: > > - Add missing include for gpio. > > - Expand GPIO descrption to include hardware synchronization. > > - Use led-max-microamp instead of led-current-microamp for the LDR pin. > > > > Changes in v2: > > - Add the LDR, the interrupt pin, and the GPIO pin to the bindings. > > - Fix node name and unit address mismatch. > > - Include MAINTAINERS changes. > > > > .../bindings/iio/light/ams,as7343.yaml | 66 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 72 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as7343.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml > > new file mode 100644 > > index 000000000000..7fb10b0d4843 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml > > @@ -0,0 +1,66 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/light/ams,as7343.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: AMS AS7343 14-Channel Multi-Spectral Sensor > > + > > +maintainers: > > + - Chang Yu > > + > > +description: | > > + The AMS AS7343 is a 14-channel multi-spectral sensor with i2c address of 0x39. > > + https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - ams,as7343 > > + > > + reg: > > + description: > > + I2C address of the device (0x39). > > + maxItems: 1 > > + > > + interrupts: > > + description: > > + Open drain output active low interrupt pin. > > + maxItems: 1 > > + > > + vdd-supply: true > > + > > + led-max-microamp: > > + description: > > + The driver current for the external LED connected to the LDR pin. > > + minimum: 4000 > > + maximum: 258000 > > + multipleOf: 2000 > > + default: 12000 > > + > > +required: > > + - compatible > > + - reg > > + - vdd-supply > > + > > +additionalProperties: false > > Should be unevaluatedProperties as you're using $refs in the binding, > but Jonathan could tweak that when applying. > There was a discussion about this back in v2 in which Conor was suggesting keeping additionalProperties: false if I recall. I don't know the exact pros vs cons so I'll defer to the experts here.