From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CF2518125; Tue, 13 Oct 2026 15:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791906371; cv=none; b=CIu3/EX3nLNXDPsavcgxZhiS+bmeTaqm/Cuis2VSItxRc48uymPzrIHJNnnLbuFQDBior6hb78XcT5iZuQbKF1AkZWL7nDm7bLCWrmWl6htp3t6GErbnPU5DaRK1TFpubciTjb6gKFo54ryDrglrbzc3N799AdTlw8Z30MX5c5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791906371; c=relaxed/simple; bh=HwThbKkjvPBCtT1Gbq2wq8+M2Qi7KO6/+mCjnqtq0qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dgnyxBzStyx8mHh0j7hWRQCeja1l5HTyqWhgpYx7v0y9FvEKA3nfOnvJN9E17xG61js1lsQAv53zsnb7mkykxmOJ+S+BFSDFWQ4NDpWd57oO0G6ITs/B6wRn4nMafXuEEIlTN1b9kBFSKRtYycJsOwQWyjrYiulkVYTACG7xDfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a5wV86lu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a5wV86lu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D7F11F000FF; Tue, 13 Oct 2026 15:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791906369; bh=Y6C8dHlnwEDJ1zncuSe4AUCuf3AUeAAimis8NggtjWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=a5wV86luUnEXxEJ/WMPsiL4f1xgooPCOJl4BDaSlHryWyUztKNBzJivXW9tcPW7we v22pP39rPRG3uauFSeFa9QiRrF04IMaMTrAu/b9OQASK/KUSQhWixr1UT5XtUYO/rv NI/WLSuBdnupTa29PNK0U3Is2YebXuHTAbhciWlKnqkj0puT6OlchlD/3WRqY0h5kK alyzZNkls5y2Kavi+qQ3VvVpwiJ8WJZWs46qgzPqTY+ZBpEbwMv/ea1exBvN6qzq3j XA3GzztdOp3pYUZkN0IxsxxXzA7zzToyOL4HeLMRYLubID8oCVP2wup6+8HED6cK5o +ywd085qTXbbQ== Date: Tue, 13 Oct 2026 18:45:57 +0300 From: Mike Rapoport To: Yeoreum Yun Cc: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Shuah Khan , Jason Gunthorpe , Leon Romanovsky , Sarthak Sharma Subject: Re: [PATCH v6 2/3] kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro Message-ID: References: <20261013-fix_hpage_macro-v6-0-2c52d0484de3@arm.com> <20261013-fix_hpage_macro-v6-2-2c52d0484de3@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013-fix_hpage_macro-v6-2-2c52d0484de3@arm.com> On Tue, Oct 13, 2026 at 10:46:05AM +0100, Yeoreum Yun wrote: > HPAGE_SIZE and HPAGE_SHIFT macro is written based on the 4KB PAGE_SIZE. > When this macro is used in some test, test result would be strange in > the system where PAGE_SIZE is more then 4KB. > > Here is the example with transhuge-stress test with 16KB PAGE_SIZE: > > transhuge-stress: allocate 61073 transhuge pages, using 122146 MiB virtual memory and 1908 MiB of ram > 3.292 s/loop, 0.054 ms/page, 37106.002 MiB/s 2566 succeed, 58507 failed, 2566 different pages > 0.591 s/loop, 0.010 ms/page, 206850.792 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231895.107 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231839.704 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.528 s/loop, 0.009 ms/page, 231544.782 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.528 s/loop, 0.009 ms/page, 231462.074 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231770.300 MiB/s 0 succeed, 61073 failed, 0 different pages > ... > ok 1 Completed > > Remove the HPAGE_SIZE and HPAGE_SHIFT macro and introduce pmd_pshift() > helper to get the HPAGE_SHIFT properly. For HPAGE_SIZE, use pre-existing > helper, pmd_psize(). > > Also, run the KSM_MERGE_TIME_HUGE_PAGES test with a size of 512 MiB, > which is the least common multiple of the PMD sizes for 4 KiB, 16 KiB, > and 64 KiB base pages. Since allocate_transhuge() allocates mappings in > PMD-sized units, the test may fail with the previous size of 100 MiB, > which is not a multiple of the PMD size when the base page size is > 16 KiB or 64 KiB. > > After this patch, output of transhuge-stress: > > transhuge-stress: allocate 3817 transhuge pages, using 122146 MiB virtual memory and 119 MiB of ram > 2.558 s/loop, 0.670 ms/page, 47755.759 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.640 s/loop, 0.692 ms/page, 46268.432 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.635 s/loop, 0.690 ms/page, 46360.298 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.782 s/loop, 0.729 ms/page, 43899.795 MiB/s 2616 succeed, 1201 failed, 2616 different pages > 2.692 s/loop, 0.705 ms/page, 45380.876 MiB/s 2627 succeed, 1190 failed, 2627 different pages > 2.612 s/loop, 0.684 ms/page, 46765.812 MiB/s 2628 succeed, 1189 failed, 2628 different pages > 2.683 s/loop, 0.703 ms/page, 45520.990 MiB/s 2630 succeed, 1187 failed, 2630 different pages > 2.727 s/loop, 0.714 ms/page, 44789.321 MiB/s 2631 succeed, 1186 failed, 2631 different pages > ... > ok 1 Completed > > Suggested-by: Lorenzo Stoakes (ARM) > Tested-by: Sarthak Sharma > Reviewed-by: Zi Yan > Reviewed-by: Sarthak Sharma > Signed-off-by: Yeoreum Yun Acked-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/guard-regions.c | 10 +++++-- > tools/testing/selftests/mm/ksm_tests.c | 16 ++++++----- > tools/testing/selftests/mm/run_vmtests.sh | 4 +-- > tools/testing/selftests/mm/transhuge-stress.c | 25 +++++++++++------- > tools/testing/selftests/mm/vm_util.c | 38 +++++++++++++++++++++++---- > tools/testing/selftests/mm/vm_util.h | 9 +++---- > 6 files changed, 71 insertions(+), 31 deletions(-) -- Sincerely yours, Mike.