mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Frank Li <Frank.Li@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: bestcomm: drop unneeded sram exports
Date: Tue, 13 Oct 2026 16:41:42 -0400	[thread overview]
Message-ID: <as6Xhp7ldXkA0CFh@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260915180919.8899-1-rosenp@gmail.com>

On Tue, Sep 15, 2026 at 11:09:19AM -0700, Rosen Penev wrote:
> bcom_sram_init(), bcom_sram_cleanup(), bcom_sram_alloc() and
> bcom_sram_free() are only called from bestcomm.c, which is part of
> the same bestcomm-core module as sram.c.  Remove the now-pointless
> EXPORT_SYMBOL_GPL() statements; the functions stay non-static because
> they cross compilation units within the module.  bcom_sram itself
> remains exported for the inline helpers in sram.h.
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/bestcomm/sram.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/sram.c b/drivers/dma/bestcomm/sram.c
> index 09ef5142c26c..d33e0f931682 100644
> --- a/drivers/dma/bestcomm/sram.c
> +++ b/drivers/dma/bestcomm/sram.c
> @@ -119,7 +119,6 @@ int bcom_sram_init(struct device_node *sram_node, char *owner)
>
>  	return rv;
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_init);
>
>  void bcom_sram_cleanup(void)
>  {
> @@ -132,7 +131,6 @@ void bcom_sram_cleanup(void)
>  		bcom_sram = NULL;
>  	}
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_cleanup);
>
>  void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
>  {
> @@ -148,7 +146,6 @@ void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
>  	*phys = bcom_sram->base_phys + offset;
>  	return bcom_sram->base_virt + offset;
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_alloc);
>
>  void bcom_sram_free(void *ptr)
>  {
> @@ -163,4 +160,3 @@ void bcom_sram_free(void *ptr)
>  	rh_free(bcom_sram->rh, offset);
>  	spin_unlock(&bcom_sram->lock);
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_free);
> --
> 2.55.0
>

  reply	other threads:[~2026-10-13 20:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 18:09 Rosen Penev
2026-10-13 20:41 ` Frank Li [this message]
2026-11-20 10:00 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as6Xhp7ldXkA0CFh@lizhi-Precision-Tower-5810 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®