From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0615335E931 for ; Fri, 2 Oct 2026 20:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790974236; cv=none; b=YnMbdy0+uwf3C9NyOIYO+M2f+g0d4Y8ILGxH4e7RN+8zrqW5lmEz0DXo9amKjoYiWyrZzcx6OgPnBAGFxj+Wz041sLS3TQkhaIo1AQ6/qJg6BFNu1sSxmKmUwMDNePZri0121AtFiYkJ1r5LNejFqpfaofe28wDrcc+EOfTyYc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790974236; c=relaxed/simple; bh=r0wAsCW09uYJLGw/k9Eanv0esNYUb2MmEuteA4NS4xY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WP46PN8t8YtGOHdjVUwS9O5XjgloH+zpSYb35P9AmtP1fi/OsiIjmC2RiXpB3A40Gul0BmTkvPbydH18TQOZtWrn3GW2Z3XoakTaWhS7dq3qRKn0wce3wo8RqXingwighkcM7F42GNb7FIbjHRm5K1ffZkWmt92LqMnEdFnv3gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=X1UUwx/S; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="X1UUwx/S" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2e4a2daa7d7so127705ad.1 for ; Fri, 02 Oct 2026 13:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790974234; x=1791579034; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aPjEZZ9EpGI2YyupaPWjnZ3uGj54v5irCmpCUt3ENzE=; b=X1UUwx/StpRGBM3DXE758FkAphrL0xKzpMwyKedC7rBEnd3nfN1DjBMxvX/YzIj13f Mk5F54yAL9m+viVNnmI3AxVisxDYLphDUhBzbMkBdZZUfuajG3DdSkwFVKLmOlLQbRmu 3jQnN6MYv/7RWkli2HKH/yW0+8Z1vEP5n9i88kywQ65+tgYMqrP1dJ3mj8O1DMW3kFsQ 2FXGIPAJ1VUXz/FNlFMdsi0oaF/d2qXJqNPO9w0WGyADbvhXiNPefn2JoFfswFb4Pl92 A6J0HXkgN1h1ksYXAegw8LP3IvRLYDDn39jDDqYr2Jl/2zFo5LY/Mu/Y4jftqP9QBDLS YnlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790974234; x=1791579034; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=aPjEZZ9EpGI2YyupaPWjnZ3uGj54v5irCmpCUt3ENzE=; b=kmZ1Jf9wWLgPfM7Ur/AgzIa/V1PgbtSTac8mS9tePCg/e+WaZK5RaPxY8NHBrWPa6W r48cWO4DfbqpVc3srppKco/CycUnqjvMbD8BrN6vz8Mzvw72jKINmlTv5gLVak/Kucck wrhJT0iH2kZ6bnWt6ZwhPbnks6Hqmoq9Og5+gYpIB5CiHaP2ObR75XKH7O0Lsf/FWkLd pw3lw7SqrPkzvAHuwjiiwx1TlCLKiNL8VandPqHnHjMnfEzipCzqAFKmaxONUa/G7cTz LENyZzQG/8rTGPKI3HFsqrE1GxXb3VbXcBRQw3szSsYISF2N3k4SKiUtTZX/4aFq4vRa YfEA== X-Forwarded-Encrypted: i=1; AKwUvBybddWfTUKKbFN/MN6g4CbPTIVLzuKh/1vZYAbEKKZtt9HqROBAPfsuUN3mX2Z4eOz4wx9QIdPvPa4p5Jw=@vger.kernel.org X-Gm-Message-State: AFq9FYLnkLNdRpA31GyUf/9rYhWiwI2frvnuwG3zsOA6q2MXf7sWWzie OjVozpA2DPuRS0ZvNL/09FQEGbt7VO+vN+FSWzw8Tk/K0hnaI3f27QWlRs0n7vd9QLk= X-Gm-Gg: AYBFou1Zq+jUtJopTVWC0Dg8b6xuzyrIw7tNGUEuUi/C2TPcV2MrUCNZOdWo73d0K24 Ph6CVVyyzyggkMmdA9I95nxaf95wryX+9X8jEXuNMqpa0N9aHxZEFL9AuaYjOfPtuE/SlILqlu5 FBk9p7D6h8wBv9mj8r1sRGBYFH3VJAWQAOS2YqMAT5Kmm8fNaMout9NibA29z89S33mRS1KdGlF dohBFzifEIA/t9s4kRHf0uI/WjssAcG9AIHOO0Fz9yCUZ/sW3S8GpD12wRRJs89+6mJk2bEz+zA HTJhkA8CRlAJQgunXXVPI95UbHhXgWIThFXuZ52jt3MCwh/WsOQ8tPebsWU/I1YSYNUYUh/A6Ex dkXXFPK6uxY+v+oJQK6UZzDGLN3G9nvgYijEsMSAQ5cvCqYCqwcdUaSZI5ASjqUWLb3d42gYC36 MSNFC9bf+Nr7CefyLNVP+7JVURUxO1c4h+YMFe6zci95N933QJaXkm+jx9FuxmfZtKonNBnVmug 2PLXfziHWEJ X-Received: by 2002:a17:90b:1d43:b0:39e:1633:d29e with SMTP id 98e67ed59e1d1-3a786736686mr353131a91.5.1790974234324; Fri, 02 Oct 2026 13:50:34 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4e::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a78d4f7316sm60634a91.9.2026.10.02.13.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 13:50:32 -0700 (PDT) Date: Fri, 2 Oct 2026 13:50:31 -0700 From: Joe Damato To: Andy Shevchenko Cc: Andy Shevchenko , Xuan Zhuo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Gu , Philo Lu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next v2 1/5] eea: Drop temporary buffer by using %*pEhp directly Message-ID: Mail-Followup-To: Joe Damato , Andy Shevchenko , Andy Shevchenko , Xuan Zhuo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Gu , Philo Lu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20261002100035.863275-1-andriy.shevchenko@linux.intel.com> <20261002100035.863275-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261002100035.863275-2-andriy.shevchenko@linux.intel.com> On Fri, Oct 02, 2026 at 11:59:19AM +0200, Andy Shevchenko wrote: > Instead of calling string_escape_str() followed by %s specifier, > use %*pEhp specifier directly. With this being done, drop temporary > buffer. > > Note, as Sashiko pointed out in [1] the %*pEp, which is the direct > substitution of the original call to string_escape_str() with ESCAPE_NP > flag set, makes the whole thing like "no escape". To add some sanity > to this the used specifier also includes ESCAPE_HEX. > > Link: https://lore.kernel.org/r/179089728102.434549.12368098081790653201@kernel.org [1] > Signed-off-by: Andy Shevchenko > --- > drivers/net/ethernet/alibaba/eea/eea_adminq.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/alibaba/eea/eea_adminq.c b/drivers/net/ethernet/alibaba/eea/eea_adminq.c > index 73d0caf25700..f2284fc885c3 100644 > --- a/drivers/net/ethernet/alibaba/eea/eea_adminq.c > +++ b/drivers/net/ethernet/alibaba/eea/eea_adminq.c > @@ -522,16 +522,9 @@ void eea_adminq_config_host_info(struct eea_net *enet) > dev_warn(dev, "The hardware-driven state validation may be abnormal.\n"); > > if (rep->has_reply) { > - char buf[EEA_HINFO_MAX_REP_LEN] = {0}; > - > rep->reply_str[EEA_HINFO_MAX_REP_LEN - 1] = '\0'; > - > - string_escape_str(rep->reply_str, buf, sizeof(buf), > - ESCAPE_NP, NULL); > - > - buf[EEA_HINFO_MAX_REP_LEN - 1] = '\0'; > - > - dev_warn(dev, "Device replied: %s\n", buf); > + dev_warn(dev, "Device replied: %*pEhp\n", > + (int)strlen(rep->reply_str), rep->reply_str); i have no idea what this otuput could be but i suppose if you wanted to remove the terminator write above, you could do: strnlen(rep->reply_str, ....) instead, but that feels like a fairly useless nit so: Reviewed-by: Joe Damato