From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: Move SipHash into lib/crypto/
Date: Sat, 3 Oct 2026 05:49:21 +0200 [thread overview]
Message-ID: <asB7QVFMlgKgbje2@zx2c4.com> (raw)
In-Reply-To: <20261002223708.39183-1-ebiggers@kernel.org>
On Fri, Oct 02, 2026 at 03:37:08PM -0700, Eric Biggers wrote:
> The addition of SipHash to lib/ predated the existence of the
> lib/crypto/ directory. Since it's a cryptographic algorithm, move it
> from the top-level lib/ directory to lib/crypto/.
>
> Specifically:
>
> - Move both siphash.c and siphash_kunit.c. Keep the header
> <linux/siphash.h> as-is for now.
>
> - Keep the dedicated MAINTAINERS entry for SipHash. Just update the
> file paths it references.
Given that I'm also listed in the crypto section, I think we may as well
delete the whole separate entry.
The only downside of this change is that those hsiphash functions are,
erm, a bit less than cryptographic-strength. But maybe such concerns
don't really matter any more at this stage, and we might as well group
it all in lib/crypto/ where it all belonged originally anyway.
Acked-by: Jason A. Donenfeld <Jason@zx2c4.com>
Jason
next prev parent reply other threads:[~2026-10-03 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 22:37 Eric Biggers
2026-10-03 3:49 ` Jason A. Donenfeld [this message]
2026-10-03 7:31 ` Ard Biesheuvel
2026-10-03 16:30 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asB7QVFMlgKgbje2@zx2c4.com \
--to=jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®