From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EAB63909A4 for ; Sat, 3 Oct 2026 07:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791014381; cv=none; b=CBxS9DEWxWhJ1OoHY/e1p/Pbkjk/Qr/Duclvuc5FXKYr9MW65twHV5qaGzZUpAHw0MR6kijluc4badqw1Rln8ch6o9iGDrGKKoq3kDiSCZ27Nj+eaqg9vUmEsQkNyZLsLdJ5so5yAU9jtlLMN6ULxsWb0w6eQw89Yx8WaEiNRtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791014381; c=relaxed/simple; bh=RP+TlQuIj6uY0UIDbGiKpiJ7SsK7H9gZbfNBG7uhMBI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AkvakMRQOW32hvypVpJI7+RDc+NWSCygFcDVRjTuMF2IWze84EwT3DA7xX8zUtuvjkOpCFWNqI8PvV1F3jHjyG5xxntYOx+A4yGKdy87EOa1BzzdE9hrZ9D7QIAfBJKZIyvQeV4qa4mvPQAeFY3yjzGPqQcFTXp0msbnkzJqhGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RxaGWxF3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RxaGWxF3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C4E41F0089C; Sat, 3 Oct 2026 07:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791014379; bh=q9kqnwZJAXRfho77Yt6ZBil51mcAO7in4pebx6oB4fI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=RxaGWxF3L4YTsdWVZArvggDDeEJeU5k2/xlxIc3gGpz9W2LTy5PnXLsH5+kmuA34l k8k51YV/fJQ4zDkpUft0AkWeshphy5QyCqQfcNbiUSKgGpciheKBpVzcofbgs97eE+ wrOA+at67oZyPaecBMS1VaV3N/LOSsqgz2V6KBGkG3g4Ovu6kMPODYpET/eI9SE27J qSflSFBiZUZIj5pjUMyuBrQaWTon+QBk3OhV4WDI/09aTJJ+EEuygjRW4EYljdZ278 U9nho+HEBe2izjuNJGGYvx0UqAnGrAKxpPaS9uwbTu330E801mo+wf4ghP1FOIUDDd yf8LCtugigeuw== Date: Sat, 3 Oct 2026 09:59:32 +0200 From: Mike Rapoport To: Sourabh Jain Cc: kexec@lists.infradead.org, Aditya Gupta , Alexander Graf , Andrew Morton , Baoquan He , "Christophe Leroy (CS GROUP)" , Hari Bathini , Madhavan Srinivasan , Mahesh Salgaonkar , Michael Ellerman , Nicholas Piggin , Pasha Tatashin , Pratyush Yadav , "Ritesh Harjani (IBM)" , Shivang Upadhyay , Shrikanth Hegde , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 1/2] kho: check scratch vs CMA alignment at runtime Message-ID: References: <20260928083226.107807-1-sourabhjain@linux.ibm.com> <20260928083226.107807-2-sourabhjain@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260928083226.107807-2-sourabhjain@linux.ibm.com> Hi, On Mon, Sep 28, 2026 at 02:02:25PM +0530, Sourabh Jain wrote: > KHO requires the scratch alignment to be at least CMA_MIN_ALIGNMENT_BYTES, > and this is currently enforced with a static_assert(). > > That assertion breaks the build on powerpc once CONFIG_KEXEC_HANDOVER is > enabled together with CONFIG_TRANSPARENT_HUGEPAGE or CONFIG_HUGETLB_PAGE: > > kernel/liveupdate/kexec_handover.c:49:39: error: expression in static assertion is not constant > 49 | static_assert(SCRATCH_ALIGNMENT_BYTES >= CMA_MIN_ALIGNMENT_BYTES); > ./include/linux/build_bug.h:80:56: note: in definition of macro '__static_assert' > 80 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > | ^~~~ > kernel/liveupdate/kexec_handover.c:49:1: note: in expansion of macro 'static_assert' > 49 | static_assert(SCRATCH_ALIGNMENT_BYTES >= CMA_MIN_ALIGNMENT_BYTES); > > CMA_MIN_ALIGNMENT_BYTES depends on pageblock_order, which is not a > compile-time constant with certain configs, such as > CONFIG_HUGETLB_PAGE_SIZE_VARIABLE on powerpc. The next patch in this > series enables KHO on powerpc, so the alignment must be checked at > runtime instead. > > Replace the static_assert() with a runtime check at the start of > kho_reserve_scratch(), before any scratch memory is reserved. If the > scratch alignment is smaller than the CMA minimum alignment, warn once > and disable KHO rather than continue with a misaligned reservation. Can we keep static_assert() for everything !powerpc please? Like something along these lines: #ifndef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE #define check_scratch_alignment static_assert(...) #else static inline bool check_scratch_alignment() { ... } #endif > Cc: Aditya Gupta > Cc: Alexander Graf > Cc: Andrew Morton > Cc: Baoquan He > Cc: Christophe Leroy (CS GROUP) > Cc: Hari Bathini > Cc: Madhavan Srinivasan > Cc: Mahesh Salgaonkar > Cc: Michael Ellerman > Cc: Mike Rapoport > Cc: Nicholas Piggin > Cc: Pasha Tatashin > Cc: Pratyush Yadav > Cc: Ritesh Harjani (IBM) > Cc: Shivang Upadhyay > Cc: Shrikanth Hegde > Cc: linux-kernel@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Sourabh Jain > --- > kernel/liveupdate/kexec_handover.c | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c > index 7c4d86daf86d..dc76dd6b74da 100644 > --- a/kernel/liveupdate/kexec_handover.c > +++ b/kernel/liveupdate/kexec_handover.c > @@ -39,15 +39,7 @@ > #include "../kexec_internal.h" > #include "kexec_handover_internal.h" > > -/* > - * This is the minimal alignment required by deferred struct page init. > - * deferred_init_memmap_chunk frees memory to the buddy allocator, which looks > - * at the neighboring pages (up to MAX_PAGE_ORDER) to merge them. > - * If KHO scratch is not aligned to that value, buddy can access uninitialized > - * struct pages, which can cause a crash. > - */ > #define SCRATCH_ALIGNMENT_BYTES (PAGE_SIZE * MAX_ORDER_NR_PAGES) > -static_assert(SCRATCH_ALIGNMENT_BYTES >= CMA_MIN_ALIGNMENT_BYTES); > > /* The magic token for preserved pages */ > #define KHO_PAGE_MAGIC 0x4b484f50U /* ASCII for 'KHOP' */ > @@ -836,6 +828,21 @@ static void __init kho_reserve_scratch(void) > if (!kho_enable) > return; > > + /* > + * This is the minimal alignment required by deferred struct page init. > + * deferred_init_memmap_chunk frees memory to the buddy allocator, which looks > + * at the neighboring pages (up to MAX_PAGE_ORDER) to merge them. > + * If KHO scratch is not aligned to that value, buddy can access uninitialized > + * struct pages, which can cause a crash. > + */ > + if (WARN_ON_ONCE(SCRATCH_ALIGNMENT_BYTES < CMA_MIN_ALIGNMENT_BYTES)) { > + pr_err("scratch alignment %lu < CMA minimum %lu, disabling\n", > + (unsigned long)SCRATCH_ALIGNMENT_BYTES, > + (unsigned long)CMA_MIN_ALIGNMENT_BYTES); > + kho_enable = false; > + return; > + } > + > scratch_size_update(); > > /* FIXME: deal with node hot-plug/remove */ > -- > 2.55.0 > -- Sincerely yours, Mike.