mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Yoshinori Sato <yoshinori.sato@nifty.com>,
	 Rich Felker <dalias@libc.org>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: sh7785lcr: register the PCA9564 as I2C bus 0
Date: Sat, 3 Oct 2026 11:51:03 +0200	[thread overview]
Message-ID: <asDOl5bvtlbauh9x@gmail.com> (raw)
In-Reply-To: <e3c88969f18c493859f7c382db7ed2afeb15b4fa.camel@physik.fu-berlin.de>

On Sat, Oct 03, 2026 at 11:38:43AM +0100, John Paul Adrian Glaubitz wrote:
> > Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> 
> I have to admit though I don't fully understand the description of this
> patch. Either I don't have enough coffee or it's not precise enough.
> 

Thanks for testing and reviewing! I agree the changelog doesn't explain
why -1 is wrong and 0 is right for this board very clearly. I'll give it
a day or so to step back and submit a v2 with your tags and a better
changelog.

Karl

  reply	other threads:[~2026-10-03  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03  8:28 Karl Mehltretter
2026-10-03  8:53 ` John Paul Adrian Glaubitz
2026-10-03  9:07 ` John Paul Adrian Glaubitz
2026-10-03  9:38   ` John Paul Adrian Glaubitz
2026-10-03  9:51     ` Karl Mehltretter [this message]
2026-10-03  9:57       ` John Paul Adrian Glaubitz
2026-10-03 12:52       ` Geert Uytterhoeven
2026-10-03 18:17         ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asDOl5bvtlbauh9x@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=yoshinori.sato@nifty.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®