From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Damato <joe@dama.to>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wen Gu <guwen@linux.alibaba.com>,
Philo Lu <lulie@linux.alibaba.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 1/5] eea: Drop temporary buffer by using %*pEhp directly
Date: Sat, 3 Oct 2026 17:47:26 +0300 [thread overview]
Message-ID: <asEVfjCp3cUAv50m@ashevche-desk.local> (raw)
In-Reply-To: <asAZF53tsdq/QAYv@devvm20253.cco0.facebook.com>
On Fri, Oct 02, 2026 at 01:50:31PM -0700, Joe Damato wrote:
> On Fri, Oct 02, 2026 at 11:59:19AM +0200, Andy Shevchenko wrote:
...
> > rep->reply_str[EEA_HINFO_MAX_REP_LEN - 1] = '\0';
^^^ (see below)
> > + dev_warn(dev, "Device replied: %*pEhp\n",
> > + (int)strlen(rep->reply_str), rep->reply_str);
>
> i have no idea what this otuput could be but i suppose if you wanted to remove
> the terminator write above, you could do:
>
> strnlen(rep->reply_str, ....)
I haven't touched original code, which as you see above NUL-terminates
the reply string. So this has no difference with strlen(), but the latter
is shorter (doesn't need an additional argument).
> instead, but that feels like a fairly useless nit so:
Indeed :-)
> Reviewed-by: Joe Damato <joe@dama.to>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-03 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 9:59 [PATCH net-next v2 0/5] eea: Improvements in the driver Andy Shevchenko
2026-10-02 9:59 ` [PATCH net-next v2 1/5] eea: Drop temporary buffer by using %*pEhp directly Andy Shevchenko
2026-10-02 20:50 ` Joe Damato
2026-10-03 14:47 ` Andy Shevchenko [this message]
2026-10-02 9:59 ` [PATCH net-next v2 2/5] eea: Remove unneeded assignment Andy Shevchenko
2026-10-02 20:33 ` Joe Damato
2026-10-02 9:59 ` [PATCH net-next v2 3/5] eea: Refactor error handling in eea_adminq_config_host_info() Andy Shevchenko
2026-10-02 20:37 ` Joe Damato
2026-10-02 9:59 ` [PATCH net-next v2 4/5] eea: unify return code variable name Andy Shevchenko
2026-10-02 20:40 ` Joe Damato
2026-10-02 9:59 ` [PATCH net-next v2 5/5] eea: Use 2-argument strscpy() Andy Shevchenko
2026-10-02 20:42 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asEVfjCp3cUAv50m@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=guwen@linux.alibaba.com \
--cc=joe@dama.to \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®