From: Sean Young <sean@mess.org>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH] media: rc: Fix simulated TX timer lifecycle
Date: Sun, 4 Oct 2026 12:21:13 +0100 [thread overview]
Message-ID: <asI2qe_wzS-VYFYX@extorris.mess.org> (raw)
In-Reply-To: <20261004094507.1191384-1-runyu.xiao@seu.edu.cn>
On Sun, Oct 04, 2026 at 05:45:07PM +0800, Runyu Xiao wrote:
> On Tue, Sep 29, 2026 at 05:20:25PM +0100, Sean Young wrote:
> > I think this patch is correct, but I am not sure txsim is really needed
> > in the source code. Maybe it's better to just remove txsim module parameter
> > and all related code.
>
> The txsim parameter enables the driver to expose TX on hardware without
> native TX support by simulating TX completion. I found no in-tree references
> outside ene_ir.c and no separate documentation for txsim. Removing it would
> drop that fallback. Do you consider this fallback obsolete and prefer
> removing it in this change? If so, I can revise the patch to remove txsim and
> its related code; otherwise, I will keep the timer-lifecycle fix separate
> from that cleanup.
If the hardware has no TX capability then what is the point of those code
paths other than exercises the code paths. Might as well go (unless I missed
something)
Sean
next prev parent reply other threads:[~2026-10-04 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 14:31 Runyu Xiao
2026-09-29 16:20 ` Sean Young
2026-10-04 9:45 ` Runyu Xiao
2026-10-04 11:21 ` Sean Young [this message]
2026-10-04 12:37 ` Runyu Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asI2qe_wzS-VYFYX@extorris.mess.org \
--to=sean@mess.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®