From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D9945474E for ; Mon, 5 Oct 2026 06:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791180506; cv=none; b=bC73hJS3PR1iN8B6a2RbbiMLWb8uw5cVy39KCwKAI8Vj2DMn233lyIZj30FpTdrjISyfsjCL8N8y6HFFFA7cjCcyC1VU3Ktgx4nXoW9C5y/UkSsho/5ITQF0l/ocT0ecDjG0WZ9V+jNzUt3G5ufqFr7OQTY9dZNXEblToVXmDlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791180506; c=relaxed/simple; bh=/szOEFlEuCK8HzH40tWXZI0IjYEZzIV5NiqgkgiQ/q8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GzkNWqttfwfvwRBrn1ulYehzoe+fHEGiOl2x4JEIFERLpf7RsYX8NGx/bMaYgQ5K5UiVyX0oCf2HJh9mGJkP15VuDN00/zI1H2GY2iu233ux6yY8XDMpw+TLeDd6LoyUwmR8WdaleC2/G/GrhPZAWsFLXyEOLZxft9MCvVlpktw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CBzKuRp6; arc=none smtp.client-ip=209.85.210.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CBzKuRp6" Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-88b9d8c9e55so1186856b3a.1 for ; Sun, 04 Oct 2026 23:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791180504; x=1791785304; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IITz2XbwrAyv27W8DNZJyeO2sE+zaKLd0NzyMXZbO5I=; b=CBzKuRp6NUdR1iVhRMhStG+t8DgZsrWN3udvwyk4jhHo8qX2g2yLzD8k8KPaIfnkwo lHwFZbJd2KhjYLkxQG6qD34vAMBcKjjbIJ99dMrYuenovomgB2WDQvjIHe8KtGbJDzMy dwX8duBOLDFMpiMHRgJljxmtXMErfaKBBulzKh8nEBxmdB5CTEayxPtinOrkBLTvXSlp /3TbucqyOD1oNjejh116hgdvC6h1aP3EIRxlpXpOOB9HiWQT42u11EgEBMUeRk3+uGGI vL2bwTHVHjkgrvBplbhysprpArScuLDetpJSIe3EWV4RZg1wGvpxW9zx3vB+w9ha0qm/ 9bAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791180504; x=1791785304; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IITz2XbwrAyv27W8DNZJyeO2sE+zaKLd0NzyMXZbO5I=; b=wQr7Y69vAoBEDB88Yal7KesbrLC0OuD90LBiwFxK+fkfeo4Ug8MgmH4gdbsnDIQihv j8KCRztwbOP+LWwg1O9qomwBqViGlmBs05n9z5Vmitw8lez+yYADEmVQUKO2LVWLXSd2 k0WLDfaq4j5UsxgRzC88IWZb74bpF3sQoqcDuSVg2FYesYya8k2rMH5Zv2LWnL4PK5R+ /t0NfrrwXez7s02YeTDtuA+mZpAxh0jUEtD88ex6v5YlC+PQLxucTWS5MdYaoXUVr/Mh 2aaDfSqjF1PZwKKFJGd4rcK5C4vHc+RndGdcP8Rt7bSS28bWRPPtd/sX+hNlnrzX8qai 8iPw== X-Forwarded-Encrypted: i=1; AKwUvBwYo8PkltlHUyOwauQq6VytaTUebwF5nV9A+TbQ3k9n49aXIOptYoapK0v4AdSWM4hsVlzY9xEx1JwApmc=@vger.kernel.org X-Gm-Message-State: AFuF++lAXKLryP7gXCMeQEFal5RSrC8e/zaW6zPTULmJM5D5mQxs72R3 iL+5t5dHpWNjbzbDEl8rVzzN23fSndhuMzHES+xesrIrZWYdJVeLDgU+ZtIMocclkl3CLmdytHd QK/t+Wg== X-Received: from pfbga7.prod.google.com ([2002:a05:6a00:6207:b0:87f:22a2:2139]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1da4:b0:884:e190:1b94 with SMTP id d2e1a72fcca58-887fe2e5855mr8812734b3a.34.1791180504209; Sun, 04 Oct 2026 23:08:24 -0700 (PDT) Date: Sun, 4 Oct 2026 23:08:23 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH v5 0/9] KVM: selftests: add powerpc support From: Sean Christopherson To: Ritesh Harjani Cc: kvm@vger.kernel.org, Paolo Bonzini , linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Christophe Leroy , Anushree Mathur , Venkat Rao Bagalkote , Harsh Prateek Bora , Madhavan Srinivasan , Shrikanth Hegde , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Mon, Oct 05, 2026, Ritesh Harjani wrote: > I think I'd even prefer to take on an #ifdef (to scope it to PPC if necessary) > > over open coding TEST_GEN_PROGS_COMMON. > > Sure, so will add this check for kvm_create_max_vcpus() > > #ifdef __powerpc64__ > TEST_REQUIRE(!is_pseries_lpar()); > #endif Or maybe to avoid too many ifdefs, something like: static inline kvm_is_ppc_pseries_lpar(void) { /* * Comment about how this setup has unique limitations and isn't * compatible with tests that create many VMs and/or vCPUs. */ #ifdef __powerpc64___ return !access("/proc/device-tree/rtas/ibm,hypertas-functions", F_OK); #else return false; #endif } Probably redundant naming to some extent, but having "ppc" in there would make it super obvious it's a PPC-only check. > Actually I was thinking we may as well use the same check for now for > skipping hardware_disable_test on pseries. Because there also we suffer > from the same resource limitation. Let me know if that sounds ok to you > or do you want us to skip kvm_create_max_vcpus() only for now, since it > is part of TEST_GEN_PROGS_COMMON? > > > LoongArch open coded its full test list > > for some reason, and in less than a year it has started missing out on new common > > tests. > > > >> (& maybe few others like vm_types_test) from that in v6. > > > > What's wrong with VM types test? That one really should Just Work on all > > architectures. It doesn't run on LoongArch, but I assume that's > > oversight? > > So the test doesn't fail (it gets skipped). However this cap > "KVM_CAP_VM_TYPES" is only supported on x86 and since I was planning to > open code all common tests, hence I thought I may as well not add this > in the first place. /facepalm I completely forgot KVM_CAP_VM_TYPES is x86-only. FWIW, I'd still say use TEST_GEN_PROGS_COMMON if possible. > BTW, based on this discussion, I think I will re-arrange the patches in > the following order and send a v7. (The Makefile.kvm changes will only > get added after the main patch which adds powerpc support). > > cfabdb049bd7 2026-10-05 [Ritesh Harjani (IBM)] (HEAD -> feat-ppc-kvm-selftests-new-sean-v7) KVM: selftests: Skip hardware_disable_test on pseries > 2b51fab87b95 2026-09-22 [Ritesh Harjani (IBM)] KVM: PPC: selftests: Skip idle-page check when running nested on pseries LPAR > f5d1de1be4e9 2026-10-05 [Ritesh Harjani (IBM)] KVM: selftests: Skip kvm_create_max_vcpus on pseries > e45ba15cea25 2026-10-03 [Ritesh Harjani (IBM)] KVM: PPC: selftests: Add helper for checking if running nested Doesn't this one need to come first? Or is this different than pseries LPAR? > 178c9bca0e20 2026-09-22 [Nicholas Piggin] KVM: PPC: selftests: add support for powerpc > 22320662e776 2026-09-11 [Ritesh Harjani (IBM)] KVM: selftests: Fix kvm_create_max_vcpus test for powerpc This should come before "add support for powerpc", and should have a shortlog more like "Skip max vCPU IDs test on PPC with " > 11b5712b213b 2026-09-22 [Ritesh Harjani (IBM)] KVM: selftests: Move memslot_perf_test off the 256M ELF load address > 63c900860b5f 2026-09-22 [Ritesh Harjani (IBM)] KVM: selftests: Don't limit LE dirty-bitmap bitops to s390x > > > Please let me know if this sounds ok? Ya, works for me!