From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7ECF356747; Mon, 5 Oct 2026 10:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791195176; cv=none; b=G9qKE9Cx82R3OFEVLNHBIcDfzCKzfKL3BowId6EsM3s2XdJR7rOXiVPw2qPLCCyFKGK2gyTS9tu0Gsz+Ik+7qJrA0dEKEwQwLPrfoxsNC9Oa61rCsMKKlQXsTQBxsozNlFxHyVg1U1CYwEnUHuXW2G2pQWh6pbmh4bT9HlK6LfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791195176; c=relaxed/simple; bh=5c81HyqGiDhpBxTqlTA/4q642VuWUMdcgfSUQfQB5tY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D11RXRBDM8WQEH1O9FscV1tSb5XiR8wJfMjNjdQsFPxdd2atYjLzJVh96E0bNzhzjq0NlTlxYXeIb/0rz0N/7pnWsuB5aoKco4C7KBUE1rWBO+/rjAuQKx0rvfQVbUxN1Dav13C3ZZrVwJX+3nfv+XkoWmUtimXb9kPWcjgzi6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RYA6x7w6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RYA6x7w6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E4D1F000FF; Mon, 5 Oct 2026 10:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791195174; bh=9SNdcPGhwA6p0Y49OM4WNGclRIzBx9bpXy4BEe7n/TA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=RYA6x7w65uDKnrsrTriIpnIqd6iuskr/4R4eySUnZwM3l9n5Uzt175TIkhm6/bfcu PFmhNcDfdraZQvuVEkmxQJk9iAjyy/eKzP+0kOUJ2dznVRFD7152nw1oItmwas99PE 8CAKsD3aEozz2qbGs0YDocKl1hYr0qtzkM7nKHHqXjRxmgqu+dDS3andZ5X2LZt5g/ rXSzvV82WSySTCuYtiCWf+fNxVnZkkJMv2HiQxUonmq3Lvd7QpgbM831slyUONEYNu 9cDEE9MKkpxsflpnz7pUgFf5CXtxDl7iaD8MQC/NQ1yGKFoDWui9dWcxPKjeSjg1su /mbBgKVKjZ0ng== Date: Mon, 5 Oct 2026 12:12:51 +0200 From: Vinod Koul To: Inochi Amaoto Cc: Andy Shevchenko , Jonathan Corbet , Shuah Khan , Randy Dunlap , Neil Armstrong , Manivannan Sadhasivam , Rhys Tumelty , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v4 3/5] phy: core: Add phy bulk data helper functions Message-ID: References: <20260929085235.469515-1-inochiama@gmail.com> <20260929085235.469515-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260929085235.469515-4-inochiama@gmail.com> On 29-09-26, 16:52, Inochi Amaoto wrote: > Add several helper functions that allow drivers to get several phy > consumers in one operation. If any of the phy cannot be acquired then > any phys that were got will be put before returning to the caller. Do we have many such examples? Phy is not a many resource like clock/regulators... Do we really need this. How many in kernel users will benefit from this API? > > This can relieve the driver owners' life who needs to handle many phys, > as well as each phy error reporting. > > Signed-off-by: Inochi Amaoto > --- > drivers/phy/phy-core.c | 253 ++++++++++++++++++++++++++++++++++++++++ > include/linux/phy/phy.h | 55 +++++++++ > 2 files changed, 308 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 8fbaea003b90..5b76c006575b 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -1004,6 +1004,259 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np, > } > EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index); > > +/** > + * of_phy_get_count() - Get the number of phys of a device node > + * @np: device_node for which to get the phy > + * > + * Return: the phy count if successful, %0 if no phy handle is found, > + * negative error value if error occurs. > + */ > +static int of_phy_get_count(const struct device_node *np) > +{ > + int count; > + > + count = of_count_phandle_with_args(np, "phys", "#phy-cells"); > + > + if (count == -ENOENT) > + return 0; > + > + return count; > +} > + > +/** > + * phy_bulk_put() - release a set of PHYs > + * @dev: device that acquired the PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data with PHYs set > + * > + * Releases the PHY references in reverse order and clears the PHY pointer in > + * each entry. The caller owns the phys array and is responsible for freeing it > + * if necessary. > + */ > +static void phy_bulk_put(struct device *dev, unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + while (num_phys--) { > + if (!IS_ERR_OR_NULL(phys[num_phys].phy)) > + phy_put(dev, phys[num_phys].phy); > + phys[num_phys].phy = NULL; > + } > +} > + > +/** > + * of_phy_bulk_put() - release a set of PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data with PHYs set > + * > + * Releases the PHY references in reverse order and clears the PHY pointer in > + * each entry. The caller owns the phys array and is responsible for freeing it > + * if necessary. > + */ > +static void of_phy_bulk_put(unsigned int num_phys, struct phy_bulk_data *phys) > +{ > + while (num_phys--) { > + of_phy_put(phys[num_phys].phy); > + phys[num_phys].phy = NULL; > + } > +} > + > +static int of_phy_bulk_get_by_index(struct device_node *np, > + unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + unsigned int i; > + int ret; > + > + for (i = 0; i < num_phys; i++) { > + phys[i].id = NULL; > + phys[i].phy = NULL; > + } > + > + for (i = 0; i < num_phys; i++) { > + of_property_read_string_index(np, "phy-names", i, &phys[i].id); > + > + phys[i].phy = of_phy_get_by_index(np, i); > + > + ret = PTR_ERR_OR_ZERO(phys[i].phy); > + if (ret) { > + phys[i].phy = NULL; > + goto err; > + } > + } > + > + return 0; > + > +err: > + of_phy_bulk_put(i, phys); > + > + return ret; > +} > + > +/** > + * of_phy_bulk_get_all() - obtain all PHYs from a device node > + * @np: device node containing the PHY references > + * @phys: pointer to store the allocated array of struct phy_bulk_data > + * > + * Gets every PHY referenced by the phys property in index order. PHY names are > + * read from phy-names when present. > + * > + * Return: the number of PHYs on success, %0 if no PHYs are found, or a > + * negative error code otherwise > + */ > +static int of_phy_bulk_get_all(struct device_node *np, > + struct phy_bulk_data **phys) > +{ > + struct phy_bulk_data *phy_bulk; > + int num_phys; > + int ret; > + > + num_phys = of_phy_get_count(np); > + if (num_phys <= 0) > + return num_phys; > + > + phy_bulk = kmalloc_objs(*phy_bulk, num_phys); > + if (!phy_bulk) > + return -ENOMEM; > + > + ret = of_phy_bulk_get_by_index(np, num_phys, phy_bulk); > + if (ret) { > + kfree(phy_bulk); > + return ret; > + } > + > + *phys = phy_bulk; > + > + return num_phys; > +} > + > +/** > + * phy_bulk_put_all() - release and free PHYs > + * @dev: device that acquired the PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data to release and free > + */ > +static void phy_bulk_put_all(struct device *dev, unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + if (IS_ERR_OR_NULL(phys)) > + return; > + > + phy_bulk_put(dev, num_phys, phys); > + kfree(phys); > +} > + > +/** > + * phy_bulk_init() - initialize multiple PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data to initialize > + * > + * Initializes the PHYs in array order. If an initialization fails, all PHYs > + * initialized by this call are exited in reverse order. > + * > + * Return: %0 if successful, a negative error code otherwise > + */ > +int phy_bulk_init(unsigned int num_phys, struct phy_bulk_data *phys) > +{ > + unsigned int i; > + int ret; > + > + for (i = 0; i < num_phys; i++) { > + ret = phy_init(phys[i].phy); > + if (ret) > + goto err; > + } > + > + return 0; > + > +err: > + while (i--) > + phy_exit(phys[i].phy); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_bulk_init); > + > +/** > + * phy_bulk_exit() - exit multiple PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data to exit > + * > + * Exits the PHYs in reverse array order. All PHYs are processed even if an > + * error occurs. > + * > + * Return: %0 if successful, the first negative error code otherwise > + */ > +int phy_bulk_exit(unsigned int num_phys, struct phy_bulk_data *phys) > +{ > + int ret = 0; > + int err; > + > + while (num_phys--) { > + err = phy_exit(phys[num_phys].phy); > + if (err && !ret) > + ret = err; > + } > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_bulk_exit); > + > +/** > + * phy_bulk_power_on() - power on multiple PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data to power on > + * > + * Powers on the PHYs in array order. If a power-on operation fails, all PHYs > + * powered on by this call are powered off in reverse order. > + * > + * Return: %0 if successful, a negative error code otherwise > + */ > +int phy_bulk_power_on(unsigned int num_phys, struct phy_bulk_data *phys) > +{ > + unsigned int i; > + int ret; > + > + for (i = 0; i < num_phys; i++) { > + ret = phy_power_on(phys[i].phy); > + if (ret) > + goto err; > + } > + > + return 0; > + > +err: > + while (i--) > + phy_power_off(phys[i].phy); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_bulk_power_on); > + > +/** > + * phy_bulk_power_off() - power off multiple PHYs > + * @num_phys: number of entries in the phys array > + * @phys: array of struct phy_bulk_data to power off > + * > + * Powers off the PHYs in reverse array order. All PHYs are processed even if > + * an error occurs. > + * > + * Return: %0 if successful, the first negative error code otherwise > + */ > +int phy_bulk_power_off(unsigned int num_phys, struct phy_bulk_data *phys) > +{ > + int ret = 0; > + int err; > + > + while (num_phys--) { > + err = phy_power_off(phys[num_phys].phy); > + if (err && !ret) > + ret = err; > + } > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_bulk_power_off); > + > /** > * phy_create() - create a new phy > * @dev: device that is creating the new phy > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index ea47975e288a..77d9d74682b7 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -81,6 +81,18 @@ union phy_configure_opts { > struct phy_configure_opts_hdmi hdmi; > }; > > +/** > + * struct phy_bulk_data - Data used for bulk phy operations. > + * > + * @id: phy consumer ID > + */ > +struct phy_bulk_data { > + const char *id; > + > + /* private: Internal use */ > + struct phy *phy; > +}; > + > /** > * struct phy_ops - set of function pointers for performing phy operations > * @init: operation to be performed for initializing phy > @@ -309,6 +321,12 @@ void devm_of_phy_provider_unregister(struct device *dev, > struct phy_provider *phy_provider); > int phy_create_lookup(struct phy *phy, const char *con_id, const char *dev_id); > void phy_remove_lookup(struct phy *phy, const char *con_id, const char *dev_id); > + > +int phy_bulk_init(unsigned int num_phys, struct phy_bulk_data *phys); > +int phy_bulk_exit(unsigned int num_phys, struct phy_bulk_data *phys); > +int phy_bulk_power_on(unsigned int num_phys, struct phy_bulk_data *phys); > +int phy_bulk_power_off(unsigned int num_phys, struct phy_bulk_data *phys); > + > #else > static inline int phy_pm_runtime_get(struct phy *phy) > { > @@ -493,6 +511,43 @@ static inline struct phy *devm_of_phy_get_by_index(struct device *dev, > return ERR_PTR(-ENOSYS); > } > > +static inline int phy_bulk_check_disabled(unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + if (!phys) > + return 0; > + > + for (unsigned int i = 0; i < num_phys; i++) > + if (phys[i].phy) > + return -EOPNOTSUPP; > + > + return 0; > +} > + > +static inline int phy_bulk_init(unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + return phy_bulk_check_disabled(num_phys, phys); > +} > + > +static inline int phy_bulk_exit(unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + return phy_bulk_check_disabled(num_phys, phys); > +} > + > +static inline int phy_bulk_power_on(unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + return phy_bulk_check_disabled(num_phys, phys); > +} > + > +static inline int phy_bulk_power_off(unsigned int num_phys, > + struct phy_bulk_data *phys) > +{ > + return phy_bulk_check_disabled(num_phys, phys); > +} > + > static inline void of_phy_put(struct phy *phy) > { > } > -- > 2.55.0 -- ~Vinod