From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Andrew Pam <andrew@fastmailteam.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Sebastian Reichel" <sre@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Matt DeVillier" <matt.devillier@gmail.com>,
chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: cros_charge-control: restore EC state on resume
Date: Mon, 5 Oct 2026 06:25:16 +0000 [thread overview]
Message-ID: <asNCzKz90NZUc_cR@google.com> (raw)
In-Reply-To: <8fa29694-88cb-41b7-95d6-4d2cf9647d4a@app.fastmail.com>
On Mon, Oct 05, 2026 at 03:44:45PM +1100, Andrew Pam wrote:
> On Mon, 5 Oct 2026, at 15:20, Tzung-Bi Shih wrote:
> > On Mon, Oct 05, 2026 at 09:56:06AM +1100, Andrew Pam wrote:
> > > Nothing notices the reset. Commit 4fc88ba435da ("power: supply:
> > > cros_charge-control: adopt EC charge state on probe") made the driver
> >
> > The commit 4fc88ba435da doesn't exist.
>
> Thanks for the review. The patch is against Sebastian's power-supply for-next, where that is Matt's patch you reviewed, applied on 10 September:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?id=4fc88ba435da
>
> It isn't in mainline or chrome-platform yet, so I have made that explicit in the v2 commit message.
>
> > > initialise its cached state from the EC, but it does so only on probe,
> > ^^^^
> > To be precise, this should be "to".
>
> Reworded in v2 as "made the driver adopt the EC's charge state, but only at probe".
Ah, I see. I misunderstood because the commit wasn't in my local tree.
next prev parent reply other threads:[~2026-10-05 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 22:56 Andrew Pam
2026-10-05 4:20 ` Tzung-Bi Shih
2026-10-05 4:44 ` Andrew Pam
2026-10-05 6:25 ` Tzung-Bi Shih [this message]
2026-10-05 4:34 ` [PATCH v2] " Andrew Pam
2026-10-05 6:24 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asNCzKz90NZUc_cR@google.com \
--to=tzungbi@kernel.org \
--cc=andrew@fastmailteam.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=matt.devillier@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®