Re: [PATCH v4 1/3] dt-bindings: media: i2c: Add OmniVision OV32C4

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

On Mon, Oct 05, 2026 at 11:11:46AM +0300, Sakari Ailus wrote:
> Hi Robert,
> 
> On Mon, Oct 05, 2026 at 09:10:08AM +0200, Robert Bozik wrote:
> > Add a binding for the OmniVision OV32C4, a 32 megapixel RGBC CMOS image
> > sensor with on-chip 4-cell fusion, a 4-lane MIPI CSI-2 D-PHY transmitter
> > and the standard SCCB command interface.
> > 
> > The sensor ships in laptops as an under-display camera, where it is
> > described by ACPI; the binding follows ovti,ov08x40.yaml, which covers
> > the closest relative already in tree.
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Robert Bozik <robertbozik@gmail.com>
> > ---
> > Changes in v4:
> > - No changes to the binding.
> > 
> >  .../bindings/media/i2c/ovti,ov32c4.yaml       | 105 ++++++++++++++++++
> >  1 file changed, 105 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov32c4.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov32c4.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov32c4.yaml
> > new file mode 100644
> > index 000000000..804307cd0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov32c4.yaml
> > @@ -0,0 +1,105 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov32c4.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OmniVision OV32C4 Image Sensor
> > +
> > +maintainers:
> > +  - Robert Bozik <robertbozik@gmail.com>
> > +
> > +description:
> > +  The OmniVision OV32C4 is a 32 megapixel RGBC (red, green, blue and clear)
> > +  CMOS image sensor in a 4-cell arrangement, with on-chip 4-cell fusion and
> > +  binning. It has a 6528x4896 active pixel array, a 4-lane MIPI CSI-2 D-PHY
> > +  transmitter and the standard SCCB command interface.
> > +
> > +allOf:
> > +  - $ref: /schemas/media/video-interface-devices.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: ovti,ov32c4
> > +
> > +  reg:
> > +    maxItems: 1
> 
> minItems should be 2 here, for the always-on client.

Instead, make it an items list, so that what each item is is explained.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]