From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <hebaoquan@kylinos.cn>,
David Hildenbrand <david@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>
Subject: linux-next: manual merge of the sound tree with the mm tree
Date: Mon, 5 Oct 2026 13:21:34 +0200 [thread overview]
Message-ID: <asOIPgOu7MHRPLWU@sirena.co.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
Hi all,
Today's linux-next merge of the sound tree got a conflict in:
sound/mips/snd-n64.c
between commit:
0d62c52af5499 ("ALSA: n64: don't use GFP_DMA when calling dma_alloc_coherent()")
from the mm tree and commit:
e81f85fd3ca66 ("ALSA: mips: n64: Handle card removal properly")
from the sound tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
diff --cc sound/mips/snd-n64.c
index e2cf9df15d485,8cc001c58d5e6..0000000000000
--- a/sound/mips/snd-n64.c
+++ b/sound/mips/snd-n64.c
@@@ -296,25 -305,20 +305,20 @@@ static int __init n64audio_probe(struc
spin_lock_init(&priv->chan.lock);
priv->card = card;
+ card->private_free = n64audio_free;
priv->ring_base = dma_alloc_coherent(card->dev, 32 * 1024, &priv->ring_base_dma,
- GFP_DMA|GFP_KERNEL);
+ GFP_KERNEL);
- if (!priv->ring_base) {
- err = -ENOMEM;
- goto fail_card;
- }
+ if (!priv->ring_base)
+ return -ENOMEM;
priv->mi_reg_base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(priv->mi_reg_base)) {
- err = PTR_ERR(priv->mi_reg_base);
- goto fail_dma_alloc;
- }
+ if (IS_ERR(priv->mi_reg_base))
+ return PTR_ERR(priv->mi_reg_base);
priv->ai_reg_base = devm_platform_ioremap_resource(pdev, 1);
- if (IS_ERR(priv->ai_reg_base)) {
- err = PTR_ERR(priv->ai_reg_base);
- goto fail_dma_alloc;
- }
+ if (IS_ERR(priv->ai_reg_base))
+ return PTR_ERR(priv->ai_reg_base);
err = snd_pcm_new(card, "N64 Audio", 0, 1, 0, &pcm);
if (err < 0)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next reply other threads:[~2026-10-05 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 11:21 Mark Brown [this message]
2026-10-05 13:14 ` Andrew Morton
2026-10-05 13:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asOIPgOu7MHRPLWU@sirena.co.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hebaoquan@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=tiwai@suse.de \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®