From: Vinod Koul <vkoul@kernel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Frank Li <Frank.Li@kernel.org>,
Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, brgl@kernel.org,
stable@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH v25] dmaengine: qcom: bam_dma: free interrupt before the clock in error path
Date: Mon, 5 Oct 2026 17:47:29 +0200 [thread overview]
Message-ID: <asPGkQDjiR99ih1L@parshuram> (raw)
In-Reply-To: <20261002-bam-dma-free-irq-v25-1-f39e01d19910@oss.qualcomm.com>
On 02-10-26, 10:51, Bartosz Golaszewski wrote:
> The BAM interrupt is requested with a devres helper and so on error it's
> freed after probe() returns. We disable the clock before freeing or
> masking it so it may still fire and we may end up reading BAM registers
> with clock disabled.
>
> Stop using devres for interrupts as we free it in remove() manually
> anyway. Add an appropriate label and free the interrupt before disabling
> the clock in error path and in remove().
This doesnt apply on the current code, can you pleease rebase on the
next
--
~Vinod
prev parent reply other threads:[~2026-10-05 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 8:51 Bartosz Golaszewski
2026-10-02 16:49 ` Frank Li
2026-10-05 15:46 ` Vinod Koul
2026-10-05 15:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asPGkQDjiR99ih1L@parshuram \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=agross@codeaurora.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®