mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Blum <blum@kernel.org>
To: "Habil Eren Türker" <habilerenturker@hotmail.com>
Cc: "luto@kernel.org" <luto@kernel.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] x86/vdso: Replace deprecated simple_strtoul() with kstrtouint()
Date: Mon, 5 Oct 2026 19:07:16 +0200	[thread overview]
Message-ID: <asPZRBSZy9jf06As@kernel.org> (raw)
In-Reply-To: <20261005163335.6716-1-habilerenturker@hotmail.com>

On Mon, Oct 05, 2026 at 04:33:37PM +0000, Habil Eren Türker wrote:
> This patch series replaces the deprecated simple_strtoul() function
> with the safer kstrtouint() variant in the x86 vdso setup code.
> 
> The simple_strtoul() function is deprecated as it silently ignores
> overflows. Proper bounds and lineer error checking are introduced.
> 
> Changes in v2:
> - Fixed the logical short-circuit operator bug in parsing error paths
>   where invalid inputs could trigger deceptive warning logs.
> - Refactored error handling into a linear flow with unlikely() macros
>   to avoid branch misprediction.
>  
> Habil Eren Türker (2):
>   x86/vdso: Replace deprecated simple_strtoul() with kstrtouint()
>   x86/vdso: Replace deprecated simple_strtoul() with kstrtouint() in
>     vdso_setup
> 
>  arch/x86/entry/vdso/vdso32-setup.c | 11 +++++++++--
>  arch/x86/entry/vdso/vma.c          | 15 ++++++++++++++-
>  2 files changed, 23 insertions(+), 3 deletions(-)

I submitted a very similar series a while ago [1], but haven't received
feedback yet (besides a Reviewed-by from Randy on the documentation
change).

Dave, did you have a chance to take a look at my series yet?

Thanks,
Thorsten

[1] https://lore.kernel.org/lkml/20260831101657.2947-5-blum@kernel.org/

      parent reply	other threads:[~2026-10-05 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 16:33 Habil Eren Türker
2026-10-05 16:33 ` [PATCH v2 1/2] " Habil Eren Türker
2026-10-05 16:33 ` [PATCH v2 2/2] x86/vdso: Replace deprecated simple_strtoul() with kstrtouint() in vdso_setup Habil Eren Türker
2026-10-05 17:07 ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asPZRBSZy9jf06As@kernel.org \
    --to=blum@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=habilerenturker@hotmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®