From: Deborah Brouwer <deborah.brouwer@collabora.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drm/tyr: safely write GpuInfo to userspace
Date: Mon, 5 Oct 2026 15:50:35 -0700 [thread overview]
Message-ID: <asQpu3c6fCt0_B5V@um790> (raw)
In-Reply-To: <DLPEHBOTZCCU.1DFPII93RC6LA@kernel.org>
On Sat, Sep 26, 2026 at 06:48:49PM +0200, Danilo Krummrich wrote:
> On Sat Sep 26, 2026 at 2:26 AM CEST, Deborah Brouwer wrote:
> > @@ -54,7 +54,7 @@ pub(crate) fn dev_query(
> > )
> > .writer();
> >
> > - writer.write(®_data.gpu_info)?;
> > + writer.write_slice(reg_data.gpu_info.as_bytes())?;
>
> I think we eventually want write() to require T: IntoBytes + Immutable, so I'm
> not sure there is much value going back and forth with this.
We could change UserSliceWriter::write to require T: IntoBytes + Immutable, but since
rust_binder_main.rs uses UserSliceWriter also, it’s not a trivial change.
There is value in changing this for Tyr because currently Tyr has an unsafe
implementation of AsBytes and since the panthor uapi is under development I think it
would be nicer to have a compile time check.
prev parent reply other threads:[~2026-10-05 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 0:26 [PATCH v3 0/2] " Deborah Brouwer
2026-09-26 0:26 ` [PATCH v3 1/2] rust: uapi: add zerocopy/zerocopy_derive Deborah Brouwer
2026-09-26 15:50 ` Gary Guo
2026-09-26 16:26 ` Danilo Krummrich
2026-09-26 20:59 ` Gary Guo
2026-09-26 21:38 ` Danilo Krummrich
2026-09-26 23:49 ` Gary Guo
2026-09-27 0:08 ` Miguel Ojeda
2026-10-05 22:49 ` Deborah Brouwer
2026-10-05 22:47 ` Deborah Brouwer
2026-09-26 0:26 ` [PATCH v3 2/2] drm/tyr: safely write GpuInfo to userspace Deborah Brouwer
2026-09-26 2:44 ` Daniel Almeida
2026-09-26 16:48 ` Danilo Krummrich
2026-10-05 22:50 ` Deborah Brouwer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asQpu3c6fCt0_B5V@um790 \
--to=deborah.brouwer@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®