mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	netdev-bot+sinfo@kernel.org,
	"Miguel Gazquez (Schneider Electric)"
	<miguel.gazquez@bootlin.com>,
	stable@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
	John Fastabend <john.r.fastabend@intel.com>,
	Benjamin Robin <benjamin.robin@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Victor Nogueira <victor@mojatatu.com>,
	Pedro Tammela <pctammela@mojatatu.com>,
	Simon Horman <simon.horman@corigine.com>
Subject: Re: netdev LLM review for backports (WAS: [PATCH 5.10.y] net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode)
Date: Mon, 5 Oct 2026 18:58:28 -0400	[thread overview]
Message-ID: <asQrlAkQSIGqbV7k@laps> (raw)
In-Reply-To: <1acb8eb0-3443-43e3-ab66-5328b98a6143@broadcom.com>

On Mon, Oct 05, 2026 at 02:51:18PM -0700, Florian Fainelli wrote:
>On 10/5/26 14:21, Jakub Kicinski wrote:
>>On Mon, 5 Oct 2026 10:00:46 -0400 Sasha Levin wrote:
>>>I started seeing these reviews on proposed backports of net/ commits, and while
>>>they are REALLY great for upstream commits, I do not think that these comments
>>>make sense in the context of a backport.
>>
>>Blah, sorry about that.
>>Let me add a regex on the tags to exclude patches with 5.x/6.x/7.x
>>
>
>They are useful if the backport does not cleanly cherry pick, because 
>it is possible to introduce bugs in the process of back porting a 
>specific commit. I don't think sashiko is quite smart enough to be 
>able to do that however.

Oh, sorry, I agree with Florian. To be clear, my objection was with the
questions that it's asking, not the review itself:

> - How the issue was discovered, e.g. hit in production, hit during
>   development, syzbot report, manual code inspection, LLM or static
>   analysis tool scan.
>
> - Whether the issue was actually triggered, or is only theoretical
>   (e.g. found by code inspection). If it was triggered please include
>   the symptoms, like the stack trace or error messages.

-- 
Thanks,
Sasha

      reply	other threads:[~2026-10-05 22:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 10:28 [PATCH 5.10.y] net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode Miguel Gazquez (Schneider Electric)
2026-10-05 10:33 ` netdev-bot+sinfo
2026-10-05 14:00   ` netdev LLM review for backports (WAS: [PATCH 5.10.y] net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode) Sasha Levin
2026-10-05 21:21     ` Jakub Kicinski
2026-10-05 21:51       ` Florian Fainelli
2026-10-05 22:58         ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asQrlAkQSIGqbV7k@laps \
    --to=sashal@kernel.org \
    --cc=benjamin.robin@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=florian.fainelli@broadcom.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.r.fastabend@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.gazquez@bootlin.com \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pctammela@mojatatu.com \
    --cc=simon.horman@corigine.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=victor@mojatatu.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®