mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Joey Lu <a0987203069@gmail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jacky Huang <ychuang3@nuvoton.com>,
	Shan-Chun Hung <schung@nuvoton.com>,
	Hui-Ping Chen <hpchen0nvt@gmail.com>, Joey Lu <yclu4@nuvoton.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support
Date: Tue, 6 Oct 2026 12:39:30 +0200	[thread overview]
Message-ID: <asTP4lI3psLy5GCg@parshuram> (raw)
In-Reply-To: <413f21b6-90ca-4102-9466-3cf7b9feddc3@gmail.com>

On 06-10-26, 18:22, Joey Lu wrote:
> 
> Vinod Koul 於 2026/10/6 下午 04:37 寫道:
> > On 06-10-26, 09:37, Joey Lu wrote:
> > > Vinod Koul 於 2026/10/5 下午 06:07 寫道:
> > > > >     */
> > > > >    #include <linux/bitfield.h>
> > > > >    #include <linux/clk.h>
> > > > >    #include <linux/delay.h>
> > > > > -#include <linux/io.h>
> > > > why is this dropped?
> > > This driver never did direct MMIO access (no readl()/writel()/ioremap()/
> > > __iomem), even before this series - all register access goes through
> > > regmap via syscon_regmap_lookup_by_phandle(). So linux/io.h was an
> > > unused include already, and it's dropped here as part of the broader
> > > rewrite touching this include block. Happy to keep it if you'd prefer
> > > not to bundle unrelated include cleanup into this series.
> > Then it should be a different patch explaining this
> Understood. I'll drop this change from the series. I'll leave the include
> unchanged.

Nope, pls add it, but a separate patch. This in unrelated to this one,
and should be added but as a different patch.

-- 
~Vinod

  reply	other threads:[~2026-10-06 10:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  2:08 [PATCH v6 0/3] phy: nuvoton: extend MA35D1 USB2 PHY driver for dual-port " Joey Lu
2026-09-29  2:08 ` [PATCH v6 1/3] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port and OTG Joey Lu
2026-09-29  2:08 ` [PATCH v6 2/3] arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node Joey Lu
2026-10-01  8:48   ` Jacky Huang
2026-09-29  2:08 ` [PATCH v6 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support Joey Lu
2026-10-05 10:07   ` Vinod Koul
2026-10-06  1:37     ` Joey Lu
2026-10-06  8:37       ` Vinod Koul
2026-10-06 10:22         ` Joey Lu
2026-10-06 10:39           ` Vinod Koul [this message]
2026-10-06 10:43             ` Joey Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asTP4lI3psLy5GCg@parshuram \
    --to=vkoul@kernel.org \
    --cc=a0987203069@gmail.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hpchen0nvt@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=schung@nuvoton.com \
    --cc=ychuang3@nuvoton.com \
    --cc=yclu4@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®