From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 418CE4A64E8 for ; Tue, 6 Oct 2026 23:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791330126; cv=none; b=ITB56CWETeGQNg/Fo+K4UwXBlbimwJG2OOUmD3Qw4/peym5gJHxSNEL0KBvPYATxZ0NSTabU6EZ6vnrV2JIPMIklbpgMge0gF2gSCBEkzYrfj8xBsbj/v2yFUT3nP5ElU2vA+1a16BjGMLFkKAu4L5RE9HN4Mlghmji3v57oF60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791330126; c=relaxed/simple; bh=IxHD8EsJvKBJ4mWzOOAhpewIyTVODpY0N6LJF3B0ba8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SdWxRgtPT27o8//B/q/4141XfDhTgxMRObR+DBylBvAAU2cSc+QRw5XbpPMnk53S3pdGhVfU56IwGfE+M3n61G0vB+dsncambASZfUFugVC02S8QfWwMRNd8mEWhSYiXun5tEA9pCE5pwn40nGWSA7/wFvDsa3FgVCeMaeeWJwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lsVW46BD; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lsVW46BD" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49fbb2acc90so11420685e9.2 for ; Tue, 06 Oct 2026 16:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791330123; x=1791934923; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xtl9xeh/w1n1/842SeGkR83P1qgAjaMld+9slL7tN5Y=; b=lsVW46BDC8HTcKESMKOwBYpYB+Luef+Krku/nfpPysjl1bjIQ578wnHi36+99Mx1q9 pf6KX1v4tPyzAiaUc1+yTVoWo34uWg9C50iIU2CbTyDD0t2iYueS1Uv69JQMoTEXJ/51 lRYdRqNQX06PCAQt0ouvn1IP/m7ayhiSWa2/gDTKUrq32xbOuaVNl4WOZRwZU1cXsHNk KLLnQ25S/ECfC4xYtjyPAb45DTekSBdpKzISg+tm3LF+oSN34IKI5XgXYiP496hr9hsV Zzl7RAcDhLE7r92dC3DnUXsRJVxBAnqduoI0mhByVxyMnBybLgm4tXsZtlV54vCtWHkX mfEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791330123; x=1791934923; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xtl9xeh/w1n1/842SeGkR83P1qgAjaMld+9slL7tN5Y=; b=kI5rWA4KEw7HlL6BvnYAblcToalVFwU9eAUk0UrqgiKUONDjLwKM+kg7d9elc0xlVp FB1Mh/bYJ995/F6eXumPz4xj3j8U5GI2dbS/qEy7ZX9JBj7w8sggnvpXcSrdE6+bdOPR 5f5cRQUNJWs7rmE2oHnJCVUuHG+eq05hHcdLU4w7HXM6MbpOigDsST7BaB/pza+heD59 m4Up0iVxRwpsH9jyPtHwRx5ocJxLofLVU2dFjyXPSDn6hfeWstJOfm3K+ESyFMoMt/eP oGEHzGikFQISnUgba/XLwsLDIMJgXztgBYeyeezyCQfgsQeqwRKjpycEswRZYHNgqxu8 0EZw== X-Forwarded-Encrypted: i=1; AKwUvBxAXJ23/cPqA+9FRRDtKdgudRTKjR3DluMr03+hAgvXrYCUWpBqnMmyKH+jBosUACnjxHg87Ny2e4keHck=@vger.kernel.org X-Gm-Message-State: AFuF++m7g9hfVo84Z254vBLoQu63AOZ99vMlgmZS2R5T+o9+igTetBL0 pS5fAT4r1dzYuWSh8nj3OhN70N0CftLaWvk1ZV1/3ywT/PJF/Gi65xgD X-Gm-Gg: AYBFou3HYN48qwbeuOn0ROUQAmgX/mkm2yZ7AVhd6kvD2TWefuBtNvGuLldvXVcAe4e pBjbKpXL8ZObN1wBr2AUxYKBvvngxd58sV5kMgMm0QBPEJnxldRiEPbBrwmcPPmZJebHrW+8wE7 LGFuiCMnAfYZKJqWmz+enwYFf+t7eRpPbj5Le7O66oiPZV9W8mif7vFLfGCQ3o5+Nsi6NH2pb5d ctxhuMFlY/kobE96okYckssVhTkdwx00ZdfC5FmenjT69s+mfDjFdhXQUAvxeauVy/t7t09n+QI NPorzUrNdoZU9heKM+BTf13SoJEZtgZLEk2guo2eYfFt13UnT7sN9BVz+Mtmd6UovRtpMdURJl2 9JWruC1vXEn1Fk/AeLfnheHJj04v8tZaW4vEGql51FnOdGXmddXIGVTh18EBSnHxBQyi7EMyA+x QSyZWmOfQrug4395J5Qbgts+y9lun8tm6wVB9edwp9wptUKZcRmIZcmu4pouDjM1L5nRIF+CukV s2sapz1lHkyfS4zNW3ZhDzysa0gVDM= X-Received: by 2002:a05:600c:1e17:b0:49d:2562:d670 with SMTP id 5b1f17b1804b1-4a180310dc1mr5435555e9.14.1791330123255; Tue, 06 Oct 2026 16:42:03 -0700 (PDT) Received: from blinky ([81.0.216.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a178c53997sm153565635e9.12.2026.10.06.16.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 16:42:02 -0700 (PDT) Date: Tue, 6 Oct 2026 16:42:01 -0700 From: Charlie Jenkins To: Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Andy Chiu , Yong-Xuan Wang , Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: KVM: Fix compilation when CONFIG_RISCV_ISA_V=n Message-ID: References: <20261006-vector_off_fix-v1-1-9e48e654d445@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006-vector_off_fix-v1-1-9e48e654d445@gmail.com> On Tue, Oct 06, 2026 at 04:39:03PM -0700, Charlie Jenkins wrote: > Fix the KVM code to use stubbed out versions of vector functions when > vector is not enabled instead of failing to compile. An alternative > approach would be to ifdef out the vector code but since a handful of > the vector code already just uses stubbed functions to tell the compiler > to drop the implementation, follow the same pattern. > > Fixes: b5060a4aa33d ("RISC-V: KVM: fix vcpu vector context handling for kernel-mode vector") > Signed-off-by: Charlie Jenkins Should have looked at the lists first, this wa already sent https://lore.kernel.org/all/20260922021823.44251-2-zhangzhanpeng.jasper@bytedance.com/. > --- > I was reviewing [1] and noticed that when I disabled FPU and tried to > compile that vector got disabled and the kernel failed to compile. > > [1] https://lore.kernel.org/all/20261006075303.205216-1-radim.krcmar@oss.qualcomm.com/ > --- > arch/riscv/include/asm/kvm_vcpu_vector.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/kvm_vcpu_vector.h b/arch/riscv/include/asm/kvm_vcpu_vector.h > index 6371d5ea5392..1c9efc6048bb 100644 > --- a/arch/riscv/include/asm/kvm_vcpu_vector.h > +++ b/arch/riscv/include/asm/kvm_vcpu_vector.h > @@ -11,9 +11,9 @@ > #define __KVM_VCPU_RISCV_VECTOR_H > > #include > +#include > > #ifdef CONFIG_RISCV_ISA_V > -#include > #include > > static __always_inline void __kvm_riscv_vector_save(struct kvm_cpu_context *context) > @@ -55,6 +55,14 @@ static inline void kvm_riscv_v_exit(void) > > struct kvm_cpu_context; > > +static __always_inline void __kvm_riscv_vector_save(struct kvm_cpu_context *context) > +{ > +} > + > +static __always_inline void __kvm_riscv_vector_restore(struct kvm_cpu_context *context) > +{ > +} > + > static inline void kvm_riscv_vcpu_vector_reset(struct kvm_vcpu *vcpu) > { > } > > --- > base-commit: a90ee4305c4a5df72c11b31dacfdc76e00fcf78a > change-id: 20261006-vector_off_fix-938d61b1f906 > > Best regards, > -- > - Charlie >