mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Daniel Palmer <daniel@thingy.jp>
Cc: linux@weissschuh.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] nolibc: Add dirfd()
Date: Wed, 7 Oct 2026 08:43:51 +0200	[thread overview]
Message-ID: <asXqJ0F1PyG5KdN3@1wt.eu> (raw)
In-Reply-To: <20261007052914.888956-1-daniel@thingy.jp>

Hi Daniel,

On Wed, Oct 07, 2026 at 02:29:11PM +0900, Daniel Palmer wrote:
> Add dirfd() to convert a DIR back to an fd for functions like fstatat()
> that take an fd.
> 
> Change log:
> v2 - Fix the name of the dirfd helper, I debated over removing the helper
>      as suggested by Thomas but it seems right to have the logic in a single
>      place.
>      Add test a basic test to make sure dirfd() actually does convert back
>      to the expected fd and using dirfd() with fstatat().

The series looks good to me:

  Reviewed-by: Willy Tarreau <w@1wt.eu>

Let's wait for Thomas in case he spots anything subtle.

Thanks!
Willy

      parent reply	other threads:[~2026-10-07  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  5:29 Daniel Palmer
2026-10-07  5:29 ` [PATCH v2 1/2] tools/nolibc: " Daniel Palmer
2026-10-07  8:03   ` Thomas Weißschuh
2026-10-07  5:29 ` [PATCH v2 2/2] selftests/nolibc: Add test for dirfd() Daniel Palmer
2026-10-07  8:09   ` Thomas Weißschuh
2026-10-07  6:43 ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asXqJ0F1PyG5KdN3@1wt.eu \
    --to=w@1wt.eu \
    --cc=daniel@thingy.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®