From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Meher Thanmaiee <meherthanmaiee.vanukuri@amd.com>
Cc: michal.simek@amd.com, tglx@kernel.org, daniel.lezcano@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com,
linux-pwm@vger.kernel.org,
Michal Wilczynski <m.wilczynski@samsung.com>
Subject: Re: [PATCH 4/5] pwm: cadence: Add TTC PWM driver
Date: Wed, 7 Oct 2026 13:41:46 +0200 [thread overview]
Message-ID: <asYvE-ThtZeYSEyk@monoceros> (raw)
In-Reply-To: <20261007-cadence-ttc-pwm-v1-4-52a95a8d98b1@amd.com>
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Hello,
On Wed, Oct 07, 2026 at 02:37:02PM +0530, Meher Thanmaiee wrote:
> +static const struct pwm_ops cdns_ttc_pwm_ops = {
> + .apply = cdns_ttc_pwm_apply,
> + .get_state = cdns_ttc_pwm_get_state,
> +};
Just a very quick review: I won't take any new drivers using .apply().
Please use the waveform stuff. And also note that there is Rust support
for PWMs, so if you're adventurous try that. (The reference in that case
would be drivers/pwm/pwm_th1520.rs.)
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-07 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 9:06 [PATCH 0/5] Add PWM support for Cadence TTC Meher Thanmaiee
2026-10-07 9:06 ` [PATCH 1/5] clocksource: timer-cadence-ttc: Move register definitions to shared header Meher Thanmaiee
2026-10-07 9:07 ` [PATCH 2/5] clocksource: timer-cadence-ttc: Allow deferred probing Meher Thanmaiee
2026-10-07 9:07 ` [PATCH 3/5] clocksource: timer-cadence-ttc: Refactor common TTC resource setup Meher Thanmaiee
2026-10-07 9:07 ` [PATCH 4/5] pwm: cadence: Add TTC PWM driver Meher Thanmaiee
2026-10-07 11:41 ` Uwe Kleine-König [this message]
2026-10-07 9:07 ` [PATCH 5/5] clocksource: timer-cadence-ttc: Add PWM auxiliary-device support Meher Thanmaiee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asYvE-ThtZeYSEyk@monoceros \
--to=ukleinek@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=git@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=meherthanmaiee.vanukuri@amd.com \
--cc=michal.simek@amd.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®