From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B3B3485CDE; Fri, 9 Oct 2026 11:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791544796; cv=none; b=odTi7tUSGo22R5wTYX5c29LJqvMAF0jtltBoQ7KVq6pgjt+RSCdtWdAWfwsk0RGfWwbSpftGOYrJwOzK4+Idyv5gP/ZvndtXacNe0r5jxyUhwNpRHN/hnuj9GsktHwo4cwX7tV8jKWticvUf0oDzh3/k6ID56kOG+aOaD2ELUqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791544796; c=relaxed/simple; bh=Kb1iHSNVlGDg0TUgo1Wz6/0jsFd0AguJCPMLi3VK0C8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ehVSaSle6EtKqspkIp9XI0WSORDTki60UWw/Toqd+jBiENhwToiB67vOnxh7UtM67Cas4wIpaichASPUciCfgRhY/6VDDrvyRpZvhsAboVz7xypjGZsNuamk+eKQoxNFtQORoZtpopWdL98MExi95AIoJod8dW9otyV02r0TLa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EQ1w9dMg; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EQ1w9dMg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791544788; x=1823080788; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Kb1iHSNVlGDg0TUgo1Wz6/0jsFd0AguJCPMLi3VK0C8=; b=EQ1w9dMgvF/rpnqCgNXH8YcdtvgEPH5R6K6Gv4G9o/7ufqGlpA9I/Xtd FBfxIrY3Yfy5oIAMeXrDKWXtafqfjVjZS7NCnWH22ZPvKnQjtU5pETOJe DOL13OrwjflZLkDQcR5S/qyVB50CupawnOUNyqFxthhdZgBO42B9z51pc z1VBjl/UKVW5HYUhHz6yBKpLw30AK8LK1294QXO9MXclbmzsaerPD5CsP ZgFGit2LtooVLG299LQ7FcPxs4Vmk5lRiisNOlCRkxeWyza7/0UxYOJ2f HKvigH0+cIDrFawMFjgUf3wPp24HDWAjYuqYQMWY/Yg5ARvFdx8NTMGPG g==; X-CSE-ConnectionGUID: IOdhPE+PQGuT/fmcOY5v+A== X-CSE-MsgGUID: Au/oIbKTQhiH866nESrm6w== X-IronPort-AV: E=McAfee;i="6800,10657,11929"; a="222261" X-IronPort-AV: E=Sophos;i="6.27,148,1787036400"; d="scan'208";a="222261" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2026 04:19:48 -0700 X-CSE-ConnectionGUID: RqnvWFLvSAWJY96Fq1d2lA== X-CSE-MsgGUID: 4TRnsl0rQDqFfytaPi/oug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,148,1787036400"; d="scan'208";a="252870" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa008.jf.intel.com with ESMTP; 09 Oct 2026 04:19:46 -0700 Received: by black.igk.intel.com (Postfix, from userid 1008) id 5CF9799; Fri, 09 Oct 2026 13:19:44 +0200 (CEST) Date: Fri, 9 Oct 2026 13:19:44 +0200 From: Heikki Krogerus To: amitsd@google.com Cc: Badhri Jagan Sridharan , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Andr=E9?= Draszik , RD Babiera , Kyle Tso Subject: Re: [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources Message-ID: References: <20261001-max77759-icl-typec-v1-0-99ada1f65ced@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261001-max77759-icl-typec-v1-0-99ada1f65ced@google.com> On Thu, Oct 01, 2026 at 10:51:12PM +0000, Amit Sunil Dhamne via B4 Relay wrote: > As per Sec. 4.6.2.1 of the Type-C cable & connector spec when the > source advertises Rp-default, the current limit is set as per the > USB 2.0/USB 3.2 specification, BC1.2 specification as applicable or the > PD negotiation. > > Reset value for the Input Current Limit register for the MAX77759 > charger is 500 mA. Prior to the max77759_charger driver, the battery > would always charge at that limit since it wasn't re-programmed. Since > the driver was introduced, for any non-PD source advertising Rp-default, > the charger turns off as tcpm reports the current limit to be 0. The > max77759_charger driver reads POWER_SUPPLY_PROP_CURRENT_MAX from the > "tcpm-source" power supply that tcpm_set_current_limit() updates, and > programs its input current limit from it. The limit is 0 because the > tcpm doesn't have visibility on the USB data speed or BC1.2 detection. > As a workaround for the Rp-default case, let the Type-C stack report a > USB 2.0 current limit of 500 mA so that the behavior is at parity with > what was before. This is until we implement a conduit for USB core to > communicate with the Type-C stack. > > Signed-off-by: Amit Sunil Dhamne > --- > Amit Sunil Dhamne (3): > usb: typec: tcpm: only call get_current_limit() for cc=Rp-def > usb: typec: tcpci: implement get_current_limit > usb: typec: tcpci_maxim: implement get_current_limit > > drivers/usb/typec/tcpm/tcpci.c | 14 ++++++++++++++ > drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++ > drivers/usb/typec/tcpm/tcpm.c | 7 +++---- > include/linux/usb/tcpci.h | 6 ++++++ > 4 files changed, 38 insertions(+), 4 deletions(-) > --- > base-commit: 551c722f40809618230001baccf219193e22fc5a > change-id: 20260918-max77759-icl-typec-8dfb9f83d712 > > Best regards, > -- > Amit Sunil Dhamne For the series: Acked-by: Heikki Krogerus -- heikki