From: Thorsten Blum <blum@kernel.org>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Hans Peter Anvin <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 2/3] x86/tsc: Define and use HZ_PER_KHZ and KHZ_PER_MHZ
Date: Fri, 9 Oct 2026 15:42:27 +0200 [thread overview]
Message-ID: <asjvQ-3mZzYdtTie@kernel.org> (raw)
In-Reply-To: <20261009100436.1133518-3-ptesarik@suse.com>
On Fri, Oct 09, 2026 at 12:04:35PM +0200, Petr Tesarik wrote:
> The KHZ macro is ambiguous. Sometimes it is used for conversion between Hz
> and KHz, and sometimes for conversion between KHz and MHz. Use two
> different macros to distinguish between them.
>
> Convert plain 1000 constants to one of the two macros where appropriate.
>
> No functional change intended.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> ---
> arch/x86/kernel/tsc.c | 39 ++++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index bac81d37a90ce..8b905c4dbefe2 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -41,7 +41,8 @@ EXPORT_SYMBOL(cpu_khz);
> unsigned int __read_mostly tsc_khz;
> EXPORT_SYMBOL(tsc_khz);
>
> -#define KHZ 1000
> +#define HZ_PER_KHZ 1000
> +#define KHZ_PER_MHZ 1000
These are already defined in linux/units.h.
next prev parent reply other threads:[~2026-10-09 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 10:04 [PATCH 0/3] x86/tsc: Remove some magic constants Petr Tesarik
2026-10-09 10:04 ` [PATCH 1/3] x86/tsc: Replace magic constants with xxx_PER_SEC Petr Tesarik
2026-10-09 13:37 ` Thorsten Blum
2026-10-09 10:04 ` [PATCH 2/3] x86/tsc: Define and use HZ_PER_KHZ and KHZ_PER_MHZ Petr Tesarik
2026-10-09 13:42 ` Thorsten Blum [this message]
2026-10-09 10:04 ` [PATCH 3/3] x86/tsc: Use TSC_CALIBRATE_MULT for the TSC multiplier Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asjvQ-3mZzYdtTie@kernel.org \
--to=blum@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ptesarik@suse.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®