From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: phucduc.bui@gmail.com
Cc: Mark Brown <broonie@kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: codecs: rt5659: propagate GPIO errors
Date: Fri, 9 Oct 2026 17:38:03 +0200 [thread overview]
Message-ID: <askKUo6v6qCuXwSN@analog.com> (raw)
In-Reply-To: <20261009112204.33199-2-phucduc.bui@gmail.com>
On Fri, Oct 09, 2026 at 06:22:04PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> devm_gpiod_get_optional() may return an error pointer, including
> -EPROBE_DEFER, but rt5659_i2c_probe() does not handle these errors
> for the ldo1-en GPIO and does not check for errors for the reset GPIO.
>
> Check the return values and propagate GPIO lookup errors.
>
> Fixes: d3cb2de2479b ("ASoC: rt5659: add rt5659 codec driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>
> ---
> sound/soc/codecs/rt5659.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2026-10-09 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 11:22 [PATCH 1/2] ASoC: codecs: rt5645: Simplify optional GPIO error handling phucduc.bui
2026-10-09 11:22 ` [PATCH 2/2] ASoC: codecs: rt5659: propagate GPIO errors phucduc.bui
2026-10-09 15:38 ` Alvin Šipraga [this message]
2026-10-09 15:37 ` [PATCH 1/2] ASoC: codecs: rt5645: Simplify optional GPIO error handling Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=askKUo6v6qCuXwSN@analog.com \
--to=alvin.sipraga@analog.com \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®