From: Alison Schofield <alison.schofield@intel.com>
To: Serhat Kumral <serhatkumral1@gmail.com>
Cc: <djbw@kernel.org>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>, <iweiny@kernel.org>,
<nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<error27@gmail.com>
Subject: Re: [PATCH] libnvdimm: Handle negative return from nvdimm_clear_poison() in nsio_rw_bytes()
Date: Fri, 9 Oct 2026 18:54:29 -0700 [thread overview]
Message-ID: <asma1W7snCJkrR3W@aschofie-mobl2.lan> (raw)
In-Reply-To: <20261002165641.14479-1-serhatkumral1@gmail.com>
On Fri, Oct 02, 2026 at 07:56:41PM +0300, Serhat Kumral wrote:
> When nvdimm_clear_poison() fails, it returns a negative error code.
> However, 'cleared' is a signed long while 'size' is size_t.
> The comparison 'cleared < size' promotes 'cleared' to an unsigned long.
> So the error condition can be bypassed and the function can
> incorrectly return success if the subsequent flush succeeds.
>
> Explicitly check for negative error codes before comparing with 'size'.
The fix looks good to me. Thanks for addressing this.
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
prev parent reply other threads:[~2026-10-10 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 16:56 Serhat Kumral
2026-10-02 18:07 ` Dave Jiang
2026-10-10 1:54 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asma1W7snCJkrR3W@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=error27@gmail.com \
--cc=iweiny@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=serhatkumral1@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®