From: Andi Shyti <andi.shyti@kernel.org>
To: Navon John Lukose <navonjohnlukose@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: designware: size the RX FIFO threshold to the queued transfer
Date: Sat, 10 Oct 2026 16:44:36 +0200 [thread overview]
Message-ID: <aspPNnJR5lUW4Fja@zenone.zhora.eu> (raw)
In-Reply-To: <20261007191911.502428-1-navonjohnlukose@gmail.com>
Hi Navon,
On Thu, Oct 08, 2026 at 03:52:31AM +0530, Navon John Lukose wrote:
> i2c_dw_xfer_msg() leaves DW_IC_RX_TL at the 0 that i2c_dw_configure_mode()
> writes, so the controller raises RX_FULL once per received byte. Program
> RX_TL from the reads already queued, capped at half the FIFO until the last
> message is queued, so there is room for the rest.
>
> On an Arrow Lake-H LPSS core with rx_fifo_depth 32, a 22-byte HID input
> report costs 2.00 interrupts instead of 21.43, and a 452-byte descriptor
> 0.14 interrupts per byte instead of 1.64. Polling the touchpad with
> HIDIOCGINPUT at 142 Hz draws 1.58 W less platform power (psys, 32 paired
> runs).
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Assisted-by: LLM
> Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>
pushed to i2c/i2c.
Thanks,
Andi
prev parent reply other threads:[~2026-10-10 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 22:22 Navon John Lukose
2026-10-10 14:44 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aspPNnJR5lUW4Fja@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=navonjohnlukose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®