From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD6438F254 for ; Sun, 11 Oct 2026 19:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747735; cv=none; b=LUKCM/cNOfF/R1XrUFm9pL4TnNCACfKzmEzOYZnC1i0G9TrevMgcoLbbPtE2E170a65g8cv2ebzNZqXDDe/b5hIhR7n27YsOiGQuwUqjKhzFgBzm28cjT486BKHvsqpHLZwJaC2dLnOQVrUZ12iNOUU5VRRYfBVYxd+t7pGdy94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747735; c=relaxed/simple; bh=4AMJ4/YUrPp8c+UnnNwqZYiFxBTm23GrzrPTxaOoYuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZjfApUC8HENvHcieANMjAOtBUoCUYmqG/HeCwwoyRRsf9toJr7w9r275QHFJY6Up090PT6JrqxQHFNOgNMrVhVhtkjSngpa9VBzIQD/63tO4v/NATaXnrwXEGN9HOzq0bauZVEHo6TJ7Or3eSWVweL5vNb+BRZNNrczHVfWve30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XazWImHb; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XazWImHb" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49d0da752ffso12237955e9.3 for ; Sun, 11 Oct 2026 12:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791747732; x=1792352532; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Z1QFtV7KI5OFWzwbAboD0j9bhs+VlQKq149o9ZSjG8g=; b=XazWImHbNz702kBVNRWtoiti7WE0n0wXrlG1mEZBm9Ke+hFrxjg7TxPr8S3lAZ6jt1 RBt9QDtIVI5xEtRFirEzLGViDX6SIvEiJlZFxQoa2m+Bfr+pX6sXixqRdc3/+DNZgkjo WvF+w9ybTCHojz3iB6xKt6+LSuA4xv2mslFfJ8MEZgnvXoOwPC7DMag1JP0ot0OF1eOT NEN1A8QnaMYX4UlUqWGiNo2pm3QgPDR4+2uBug4qzqFwt+NNjAyk7I5BT8sEobZbI7Gd ZomsW7zkwc7KZFLbA714kg1Fut4AbH3icjiu7sIHJVJhwWBQFVDJe46S1oQe3b12T7+d 1Pfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791747732; x=1792352532; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z1QFtV7KI5OFWzwbAboD0j9bhs+VlQKq149o9ZSjG8g=; b=eiEuQn/40UznUnz5COKZZt0RibXWvswccfzcM7cy+g7aPr49VZxHiDW4DyfX8ZU3Y+ AIRzfkNxkEDlsNydT7nC3pT1/Skb2VKoLkYwpQ95bR7OuxrgzW0+ghZyhEkMqtUKggLk MTYl3Pe7LTsIl7swzD9C9t6eYvyssWHC7QyeXwSxDuhcUOZIwXP9FqVUv7iLz9bClTRr jwoCmIOv3JkETfUZw5GLm3ZEgQ9BtjYNoEaosTA/1wx0hYq17OO+zQZ9WOzx9XkJoP2B /8wGak2hfRxu7OTiSIvior1vUSw+jwjuaDqW++k4ngHG+0kDBLbLMaBF3t3hNkpm7Iwz 0MQw== X-Forwarded-Encrypted: i=1; AKwUvBwJuTrPf9rtI8Sfsj/l7REXaXupV5vvxUhl1bftwyvaGri0AyAFv7gi2uZeiMhYQh2rHIerlroVKzGSA4M=@vger.kernel.org X-Gm-Message-State: AFq9FYJBAU3jd4qHr1uu0xzwdrVVozGHeyhSNtzKVpyHxAdZLG+oo6lQ oIjF50jAoxYmOKuZNdg13238AkMyNFfPXPcTHJ8Gm2ICqnD3xUHLm/Kd X-Gm-Gg: AYBFou23K8R1uhRxP1XwTktKMheuqfA9omkT3dwVjgTFYtlafov2MR3UQhn6hQcUAs0 9cclsbo5RLXNmgchTWM91Y+Cd2D2meeUwTcab9x0iuvlM2L9V5hhmUrG/2iah3LJbeej/ieQHF2 WjPgQxTFpKLOEXf8npfXsH1+NSlcs7FEzhumBEAyPy61knE3uqEWSFL+mEltyKEum/Up1gqi5Y9 wNCtD2vOxytAOHsqMwX3UVggFI1KooT+fxi040iOOEnJmH6Dtnu6lm5g7puOgvYm60fkRLKgY60 LtYiUTsk/r8R7zUEBLWhhv42iMM0oMypw+C2vJPy07z01mXrtmh6awX6ItA0MMTkxLiy678dZHk lNEHuiT1qGcYyh59kRrXaGv33fL1Q3dKpt604RDpyR9t6fDxMNG6A7hrzR8tBB2y/VV2slrZZF/ hufVbRToG8fzJ+WuXah/LCS3kXvkXgo8DUHwGie2tRZeXmoVDlvh7Cw8CcLQBSOTw9isQQNAYtR oWCyBUwxNoD3/ZVWh/2BZkJMqGjLam+IxbuMFcgIpEImwqGJtxsiHaGTkQg3J2G+iwaJFxeCHal FraKze8FTSS6vd7Y9I0V8r2MAGvIzOB+dIpiXFPZYtu/E8+vhKdD7Y0xBUiZwazmWAxl073JEGi N7UYu X-Received: by 2002:a05:600c:34cf:b0:4a0:159b:d2a9 with SMTP id 5b1f17b1804b1-4a18e4d68aamr114369585e9.24.1791747732221; Sun, 11 Oct 2026 12:42:12 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a124-4001-d491-d32f-6b9f-21c5.310.pool.telefonica.de. [2a02:3100:a124:4001:d491:d32f:6b9f:21c5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a197c465b4sm89015105e9.3.2026.10.11.12.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 12:42:11 -0700 (PDT) Date: Sun, 11 Oct 2026 21:42:10 +0200 From: Karl Mehltretter To: Sebastian Andrzej Siewior Cc: linux-wireless@vger.kernel.org, Arend van Spriel , Clark Williams , Steven Rostedt , "David S. Miller" , Eric Dumazet , brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: avoid sleeping tx locks in netpoll contextg Message-ID: References: <20260930185417.61865-1-kmehltretter@gmail.com> <20261001075755.3MilPS2C@linutronix.de> <20261009160015.9YCN8Lt-@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261009160015.9YCN8Lt-@linutronix.de> On Fri, Oct 09, 2026 at 06:00:15PM +0100, Sebastian Andrzej Siewior wrote: > > > > Source inspection also identified 8139too and macb as candidates: their > > transmit paths take ordinary spinlock_t locks. I have not reproduced the > > warning with either driver. > > I just replied to the netconsole thread where I did suggest to lift the > local_irq_save() part. This would obsolete this. I've replied in the netpoll thread [1]. The netpoll candidate's RT locking tests look good so far on Pi 400 with unmodified brcmfmac. > > > The earlier netpoll/NBCON discussion concerns NAPI polling and > > scheduler-lock deadlocks, rather than this driver-lock warning: > > > > https://lore.kernel.org/linux-rt-devel/20260618111554.2n0pP_O9@linutronix.de/ > > There was no fan club behind this change and PeterZ hated it so I > dropped it. > But this deadlock should not happen with nbcon or do I mix up things? No, you're not mixing things up. > I don't mind if you have something to optimise the driver. But as far as > the netconsole part goes, I would try to kill it at the upper level so > the driver is not affected. Agreed. I'll hold the driver revision while we discuss the generic fix. The generic fix still doesn't address calls to brcmfmac with interrupts disabled from non-RT netconsole or atomic writes. I still need to compare the unmodified kernel and the netpoll candidate on hardware with firmware flow control enabled (brcmfmac.fcmode=1 or 2). [1] https://lore.kernel.org/r/asveuLDEf6a44bkD@gmail.com/ Karl