From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: armandas.kvietkus@proton.me
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Griffin Kroah-Hartman <griffin.kroah@fairphone.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver
Date: Mon, 12 Oct 2026 13:10:00 +0200 [thread overview]
Message-ID: <asy_k9PGKJF9sEXZ@monoceros> (raw)
In-Reply-To: <20260930-mainlining-v2-2-40bb1b3943db@proton.me>
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Wed, Sep 30, 2026 at 07:18:51PM +0200, Armandas Kvietkus via B4 Relay wrote:
> +#include <linux/mod_devicetable.h>
You can (and should) rely on <linux/i2c.h> to provide i2c_device_id and
of_device_id. Please don't use <linux/mod_devicetable.h> which mostly
only adds unneeded build dependencies.
> +static const struct i2c_device_id aw8697_id[] = {
> + { "aw8697" },
Please use a named initializer, i.e.:
{ .name = "aw8697" },
> + { }
> +};
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-10-12 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 17:18 [PATCH v2 0/2] Input: " Armandas Kvietkus via B4 Relay
2026-09-30 17:18 ` [PATCH v2 1/2] dt-bindings: input: awinic,aw86927: Add Awinic AW8697 Armandas Kvietkus via B4 Relay
2026-10-02 6:14 ` Krzysztof Kozlowski
2026-09-30 17:18 ` [PATCH v2 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver Armandas Kvietkus via B4 Relay
2026-10-12 11:10 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asy_k9PGKJF9sEXZ@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=armandas.kvietkus@proton.me \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=griffin.kroah@fairphone.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®