From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D143358D32 for ; Mon, 12 Oct 2026 15:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791818152; cv=none; b=tZRHGlW3/MJdqj98q67zyq2tbRtL5Pm7brrjiGguRgQbNHOQLdtArq0SII1aAgeMD1YEsonRWQ2VX85+Jhh9/murG1b7AKPp/IB88EkMxhJh1JehSIC2Sn5DC5Ogb6tyTEaTZJcowzJLGCblHesyM8ozsmu2V43L/vvOTHpwKik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791818152; c=relaxed/simple; bh=AEH2va6iOCXqTJFNoLtai9BPvzPtP2b0LlMRaAMRVlM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aZt5Ts1Ha0EsL5cZS09jxDZxHplVnqnoiOqlB2y/VcbKsh24gsuR/6YFGRcUEP+eqt6Ia7ZZbdZavWO9wUnruz8sMYQQS/TDMCJ9AD5RCMsnFNXy5KJhyCy886TKyZlJ/6SaelMLFMM2WHl7iFkEE4wmpTvLht/1SXorG9FolEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NuEEtcHh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NuEEtcHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791818150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEH2va6iOCXqTJFNoLtai9BPvzPtP2b0LlMRaAMRVlM=; b=NuEEtcHhrR781xG0quwwlGnmphWUMu3fvUeSROLcN4u1YC8SO1pR9Z240fZ0zRPjOgCag6 20RD07wojy1pnCHwykv4v2TBNC0UwOWqM10U5+L0lFHH5aKqMRkJaQDFCcmyEH2UjbbBDA ehEvPLF9KEClIzUaz+ikKidyan93Z64= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-_9OIp1axOH-kjk9ybcme6g-1; Mon, 12 Oct 2026 15:15:45 +0000 X-MC-Unique: _9OIp1axOH-kjk9ybcme6g-1 X-Mimecast-MFC-AGG-ID: _9OIp1axOH-kjk9ybcme6g_1791818144 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 689C3195FCEA; Mon, 12 Oct 2026 15:15:43 +0000 (UTC) Received: from onestero-thinkpadp1gen7.tpbc.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 34D5E1956040; Mon, 12 Oct 2026 15:15:40 +0000 (UTC) Received: by onestero-thinkpadp1gen7.tpbc.csb (nbSMTP-1.00) for uid 13628 oleg@redhat.com; Mon, 12 Oct 2026 17:15:43 +0200 (CEST) Date: Mon, 12 Oct 2026 17:15:39 +0200 From: Oleg Nesterov To: Jeff Layton Cc: w15303746062@163.com, David Laight , chuck.lever@oracle.com, viro@zeniv.linux.org.uk, brauner@kernel.org, alex.aring@gmail.com, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mingyu Wang <25181214217@stu.xidian.edu.cn> Subject: Re: [PATCH v2] fs/fcntl: fix SOFTIRQ-unsafe lock order in fasync signaling Message-ID: References: <20260523135210.590928-1-w15303746062@163.com> <73b5a5174d98a3ae1dada32684e453debb8dfcd3.camel@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73b5a5174d98a3ae1dada32684e453debb8dfcd3.camel@kernel.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 10/12, Jeff Layton wrote: > > We probably should > revert this patch for now, until the problem and potential solution are > more clear. Agreed... I'll send the revert for now. Hmm. The "if (type <= PIDTYPE_TGID)" case in send_sigio/send_sigurg looks wrong too. send_sigio_to_task() -> ... -> lock_task_sighand() can fail if we race with de_thread(). Oleg.