Re: [PATCH v6 08/13] gpio: mxc: use local dev variable

[Peng Fan <peng.fan@oss.nxp.com>]

On Mon, Oct 12, 2026 at 01:39:41PM +0300, Andy Shevchenko wrote:
>On Mon, Oct 12, 2026 at 1:01 PM Peng Fan <peng.fan@oss.nxp.com> wrote:
>> On Mon, Oct 12, 2026 at 12:30:07PM +0300, Andy Shevchenko wrote:
>> >On Sun, Oct 11, 2026 at 2:54 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
>...
>
>> >>         struct device_node *np = pdev->dev.of_node;
>> >
>> >Why not this one? Is it even used? Perhaps you want to have
>>
>> of_alias_get_id() is used, there is no counterpart in fwnode api for it.
>>
>> >  struct fwnode_handle *fwnode = dev_fwnode(dev);
>> >
>> >here?
>
>What about using to_of_node() for that one and fwnode for IRQ APIs?
>
>> >> +       struct device *dev = &pdev->dev;
>
>...
>
>> >> -       dev_info(&pdev->dev, "%s failed with errno %d\n", __func__, err);
>> >> +       dev_info(dev, "%s failed with errno %d\n", __func__, err);
>> >
>> >This message simply needs to be killed, with initcall_debug in the
>> >kernel command line you will get something similar from driver core.
>>
>> ok. Let me fold the change in this patch, I would not introduce
>> another patch to just drop this line.
>
>Why not? This is a logically different change. Since the driver was
>not touched for a long time there is a technical debt, you can first
>send fixes separately, followed by a number of the drops like this one
>(remove a noisy line), followed by new features. Make it three patch
>series.

ok. let me first prepare the fixes part.

Thanks
Peng

>
>-- 
>With Best Regards,
>Andy Shevchenko
>