From: Manivannan Sadhasivam <mani@kernel.org>
To: Hongling Zeng <zenghongling@kylinos.cn>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, johan@kernel.org,
kishon@kernel.org, rogerq@ti.com, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, zhongling0719@126.com
Subject: Re: [PATCH v8 3/4] phy: ti-pipe3: Fix EPROBE_DEFER handling for clock resources
Date: Mon, 12 Oct 2026 18:29:52 +0530 [thread overview]
Message-ID: <aszY8qjMRVOjaPLp@debian> (raw)
In-Reply-To: <20260909122630.1313205-4-zenghongling@kylinos.cn>
On Wed, Sep 09, 2026 at 08:26:29PM +0800, Hongling Zeng wrote:
> ti_pipe3_get_clk() has two issues with -EPROBE_DEFER error handling:
>
> 1. When devm_clk_get() for sysclk fails, the function returns -EINVAL
> instead of propagating the actual error code. This masks -EPROBE_DEFER
> to -EINVAL, breaking the probe deferral mechanism and causing permanent
> driver initialization failure on systems with non-deterministic probe
> ordering.
>
> 2. For SATA PHY refclk, the function ignores all errors to support older
> DTBs missing the refclk property. However, this incorrectly ignores
> -EPROBE_DEFER as well, causing the driver to proceed without waiting
> for the clock provider to become available.
>
> Fix both issues:
> - Return PTR_ERR(phy->sys_clk) instead of -EINVAL to propagate all
> error codes including -EPROBE_DEFER
> - Use devm_clk_get_optional() for SATA refclk to handle optional
> clocks while propagating -EPROBE_DEFER and other errors
>
> Fixes: a70143bbef6b ("drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework")
> Fixes: 7f33912d2978 ("phy: ti-pipe3: Fix SATA across suspend/resume")
> Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2026-10-12 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 12:26 [PATCH v8 0/4] phy: ti-pipe3: Fix clock resource handling issues Hongling Zeng
2026-09-09 12:26 ` [PATCH v8 1/4] phy: ti-pipe3: Fix ignored clock enable return value in init Hongling Zeng
2026-09-09 12:26 ` [PATCH v8 2/4] phy: ti: pipe3: Fix clock resource leak on probe errors Hongling Zeng
2026-10-12 12:56 ` Manivannan Sadhasivam
2026-09-09 12:26 ` [PATCH v8 3/4] phy: ti-pipe3: Fix EPROBE_DEFER handling for clock resources Hongling Zeng
2026-10-12 12:59 ` Manivannan Sadhasivam [this message]
2026-09-09 12:26 ` [PATCH v8 4/4] phy: ti-pipe3: Fix clock leaks in init/exit error paths Hongling Zeng
2026-10-12 13:05 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aszY8qjMRVOjaPLp@debian \
--to=mani@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=rogerq@ti.com \
--cc=vkoul@kernel.org \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®