mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Hee-Suk Kim <hskim@dilluti0n.com>,
	netdev@vger.kernel.org, javen <javen_xu@realsil.com.cn>,
	nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: allow Giga Lite fallback on RTL8168EP
Date: Mon, 12 Oct 2026 14:28:26 +0100	[thread overview]
Message-ID: <aszgerrI8yoLTaX0@makrotopia.org> (raw)
In-Reply-To: <4435b286-1638-464a-821c-f486b647c9f7@lunn.ch>

On Mon, Oct 12, 2026 at 02:46:27PM +0200, Andrew Lunn wrote:
> On Sun, Oct 11, 2026 at 10:59:42PM +0200, Heiner Kallweit wrote:
> > On 10.10.2026 15:53, Hee-Suk Kim wrote:
> > > Giga Lite is a Realtek proprietary mode which allows links of up to
> > > 500 Mbps over two-pair cabling. In South Korea, it is widely used to
> > > support 500 Mbps plans by most ISPs. The vendor driver [1] sets PHY
> > > page 0xa42, reg 0x14, bit 9 to allow it on RTL8168H and FP. The driver
> > > does not handle RTL8168EP but I confirmed the same works for it by
> > > setting the PHY register via SIOCSMIIREG on an SK Broadband 500 Mbps
> > > plan [2].
> > > 
> > > With the bit set, the link still came up at about 470 Mbps even when
> > > only 10/100 was advertised. So set it only when autonegotiating with
> > > 1000baseT/Full advertised, and clear it otherwise, to respect a lower
> > > advertised speed. This matches what the vendor driver does for
> > > RTL8168H and FP.
> > > 
> > > PHYSR reports 0x30 in its speed field to denote a Giga Lite link. This
> > > value is not handled in rtlgen_decode_physr(), so the reported speed
> > > varies between 100 and 1000 Mbps on the same link. Handle it to report
> > > 1000, as there is no 500 Mbps uAPI.
> > > 
> > > [1] https://github.com/mtorromeo/r8168/blob/b3e24e4aa74a3561618d0abf01b708bd55def57a/src/r8168_n.c#L6375-L6390
> > > [2] https://www.tworld.co.kr/web/product/callplan/NI00000567
> 
> I'm in agreement with Heiner here. If we add this, we do it properly.
> 
> Please add ETHTOOL_LINK_MODE_500baseT2_Full. Make the PHY report this
> link mode in it features, add the speed, allow it to be negotiated,
> reported in ethtool etc.

While at it also consider ETHTOOL_LINK_MODE_1000baseT2_Full which is
supported as "2.5G Lite" by the RTL8221/RTL8226 2.5G PHY family.

  reply	other threads:[~2026-10-12 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 13:53 Hee-Suk Kim
2026-10-11 20:59 ` Heiner Kallweit
2026-10-12 12:46   ` Andrew Lunn
2026-10-12 13:28     ` Daniel Golle [this message]
2026-10-12 14:53       ` Hee-Suk Kim
2026-10-12 14:16   ` Hee-Suk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aszgerrI8yoLTaX0@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=hskim@dilluti0n.com \
    --cc=javen_xu@realsil.com.cn \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®