From: Gregory Price <gourry@gourry.net>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: albin_yang@163.com, akpm@linux-foundation.org,
liam@infradead.org, david@kernel.org, vbabka@kernel.org,
jannh@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, albinwyang@tencent.com
Subject: Re: [PATCH] mm/madvise: add cond_resched() in THP branch of madvise_cold_or_pageout_pte_range()
Date: Mon, 12 Oct 2026 09:32:14 -0400 [thread overview]
Message-ID: <aszhNc-Lrw7BgCT0@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <aszZPq92qX3jpsNE@gremlin>
On Mon, Oct 12, 2026 at 01:58:18PM +0100, Lorenzo Stoakes (ARM) wrote:
> On Sat, Oct 10, 2026 at 10:26:33AM -0400, Gregory Price wrote:
> > On Sat, Oct 10, 2026 at 10:40:42AM +0800, albin_yang@163.com wrote:
> >
> > This same improvement came naturally from refactoring the entire
> > function into a proper pagewalk structure:
> >
> > https://lore.kernel.org/linux-mm/20260922235830.2350770-10-gourry@gourry.net/
> >
> > this function is really nasty.
>
> Nice!
>
> And thank you for looking at this horror show of a function.
>
> But yeah as Andrew said, need something for the backport, then your work can
> help eliminate the source of such things! :)
>
Oh yeah totally reasonable, just pointing out that two separate efforts
came to the same conclusion.
~Gregory
next prev parent reply other threads:[~2026-10-12 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 2:40 albin_yang
2026-10-10 14:26 ` Gregory Price
2026-10-10 20:51 ` Andrew Morton
2026-10-12 12:58 ` Lorenzo Stoakes (ARM)
2026-10-12 13:32 ` Gregory Price [this message]
2026-10-12 13:49 ` Lorenzo Stoakes (ARM)
2026-10-12 11:02 ` David Hildenbrand (Arm)
2026-10-12 12:57 ` Lorenzo Stoakes (ARM)
2026-10-12 13:33 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aszhNc-Lrw7BgCT0@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=albin_yang@163.com \
--cc=albinwyang@tencent.com \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®