From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Thorsten Blum <blum@kernel.org>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
Kees Cook <kees@kernel.org>,
Jagadeesh Yalapalli <jagadeesh.yalapalli@einfochips.com>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accessibility: speakup: Use isdigit() in handle_goto()
Date: Mon, 12 Oct 2026 15:56:56 +0200 [thread overview]
Message-ID: <asznKOvUGKWBZKub@end> (raw)
In-Reply-To: <20261012130805.345080-4-blum@kernel.org>
Thorsten Blum, le lun. 12 oct. 2026 15:08:05 +0200, a ecrit:
> Use isdigit() to replace the open-coded implementation.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> ---
> drivers/accessibility/speakup/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
> index e9b7c2761f6f..a7c14531f2ce 100644
> --- a/drivers/accessibility/speakup/main.c
> +++ b/drivers/accessibility/speakup/main.c
> @@ -1980,7 +1980,7 @@ static int handle_goto(struct vc_data *vc, u_char type, u_char ch, u16 key)
> maxlen = (*goto_buf >= '0') ? 3 : 4;
> if ((ch == '+' || ch == '-') && num == 1)
> return 1;
> - if (ch >= '0' && ch <= '9' && num < maxlen)
> + if (isdigit(ch) && num < maxlen)
> return 1;
> if (num < maxlen - 1 || num > maxlen)
> goto oops;
>
prev parent reply other threads:[~2026-10-12 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:08 Thorsten Blum
2026-10-12 13:56 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asznKOvUGKWBZKub@end \
--to=samuel.thibault@ens-lyon.org \
--cc=blum@kernel.org \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=jagadeesh.yalapalli@einfochips.com \
--cc=kees@kernel.org \
--cc=kirk@reisers.ca \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®