From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013062.outbound.protection.outlook.com [40.107.159.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9329248F015; Mon, 12 Oct 2026 14:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791815490; cv=fail; b=i94xVMale3lOmtUM4txXV0lhZT9gI24UjuWVN/zs+C4ZjXw9RdQU4IJ7iJeyNjF8sfKUdOMoUGc+mh0LVp4iiQRFc4BnNBANXr589Ur2Zo2h9Nbia95VVidIle1fXo+lIdW/tFvYAkhwTbqbga7NuNBfXTZK7DOGg74iP9XxmXA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791815490; c=relaxed/simple; bh=BOGE2emMvkGKkFYQdXjTP+71n6e757ruhiKu+4Ts2tM=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Tk9eG+PjhLVc4edpS1aVw0fPLLi5kN5yHsgh9EAfdIfMWRJxYMU3w5s4jhPyQ/mEC88e2wPm+ox+6Ynoucuo/oEBFtgxwXjyY374slKORZcRfnEUBzTw2zUZo99Oh4DBe2Zc1rU/3H6IQ1ghn1gV6ofBb/i/BqHvZfiAAfPqe7Y= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=yJOEKwHw; arc=fail smtp.client-ip=40.107.159.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="yJOEKwHw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=peIF/XWZjnCLOkLJJQfuA0f+9icPa91ie109RO+8LWyzyziSeTB7+oaigB/7BQwNJjnbopxjjoL+CeaxqsUqFQTIZcU32zDlAzLcLDCFBHqdGQHvjaYQe6FJ4Jsi9SM0hYAD+0loCFr4gVouIuBlZ8atNzsfrY5hUem+O8Hf4GOp40pTlQUza1/FlYvJ4PiOGkopCVUAtl4uh6wG2V0ELELgyigZK+noJ/So3zbEEAFgJivuseTK4v5/SMKAq6N0QshERfXyJKouatKtyfKmmhKjqqLNFPl3k3KfcvLvUa0J/beKXDcpR2JtabgXfz5vPxZGyfOkDgub8xSDnY+Ccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXZTmKkMcGuDeUTUL96BB720ckmcOKz6q8AGXttmsO0=; b=vKZZbo/UBteJGp97s2hl8QdcfmebpDOHHZpjxcNWVN3xkHQarUyMvv6cFSwCGmqxp8+SPvXccDiFcPbLoO757nWxV9dV76cz8OdGE0mnXKalZ43541d7yZmN/Wpk/nGdg9mJ2+Yn/Hw8iN8Xrhf4WLLOMEkwYAuP/ErYEzpSV5VSqlpw+ICxJvFrn18Vnqt8naQyl/6PjZbt6W+Sibty9+iyvFiqmkwTQj+l++L1msaK+YL+HgWFmuV2kxLKgDF4hzXL3iTEGDVhGmq33OAXSDYuJbKw1v1rwEfwtDmW8HVXChGbFKUo+XVofo2XMPQ1r3qLMqihgGiCF355+ItZ7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PXZTmKkMcGuDeUTUL96BB720ckmcOKz6q8AGXttmsO0=; b=yJOEKwHwkjb7TtQFfDefoxU/eMksvxP357Edo6UxiH5jNeZL2C+6pOm5tocqNHa/JaxXZyIOAECea5FfCGiMpOrwNQsIJJub3bDj7Xz1PuyTI+rmnUDmvhGzlAxuB2M2dnvpA6PBtU2pr4Lm77bJQkEqxbDsPGE31/vB5StCeonlBYU3UA6QmXHbwlTXfYRGc4t2GlJE1GQlsppQMQdlEnVjro+0B9d+g4V4ivGxDlof4wI3AJeI8yGsauHxoE9Qm/rTd6wbtjx8t1uadlQyh6SI7LL+HsG/2RwGjbm9mSCH77k8/XAJOE2IO5nTJo8oL98Pj3GadeEgaO2Jqvy3og== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by AM9PR04MB8209.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Mon, 12 Oct 2026 14:31:25 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%7]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 14:31:25 +0000 Date: Mon, 12 Oct 2026 09:31:15 -0500 From: Frank Li To: Peng Fan Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shenwei Wang , linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v6 07/13] gpio: mxc: convert pad wakeup compatible checks to hwdata flags Message-ID: References: <20261011-gpio-mxc-cleanup-v6-0-cb47ce2ad758@nxp.com> <20261011-gpio-mxc-cleanup-v6-7-cb47ce2ad758@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PH8P221CA0049.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:346::6) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|AM9PR04MB8209:EE_ X-MS-Office365-Filtering-Correlation-Id: 598a3d88-ddab-4b60-e871-08df286d7e74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|23010399003|1800799024|7416014|376014|366016|22082099003|10067099003|18002099003|11063799006|261009223027099003|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: zUVTxd/8iXUCUdj7h2HALDQYGLZr8661pgBxSOORQVLKzQEaEH8+Je48f3JIyFHQC/c9HIR0mwqLZj/ncuGcrq3fwv9Vdje22NAVjigg6lOnTG1FxPGPo1u3WAZpPeODPm74Bq3R3UH9P1VaxgMuF+wMUzRSzOqfOJB8hXvytQ+7ECR8MJsYOz8KIMXj+vsuz061fMYIcLX8Yzwj2v/NOzZ/z2HJqcx7q1eJpGRbSX8QiCHqvEgqiGVDUathJo8rLe22BuRlQaOs26f0i3IGwr1o3AWSYrHhmA290p+BstVX5TnPO1Su+mQWosdDynpKYqALWsLM4gOY56f5JswRnN6L/V/kA5uv4VnIuD+qS6XvNjbpj7igRDUas+nhDT1Lj8vhUnubLEyb6OypMXfnLXZ9XrtGdC0VZRWzkBab1M/6P0GqiZvDZBZposHIulvzxNO7Y8n6pFuPh+Xxjj9/rC5TfEjSZoGSPW24HC7+2zKTV8XA/mK/W0aVyFpF2le780CQw4iOuwvGlM2+OG66y7VALgara0RgN5RrLAeIfb8NymZ+dP/E/mwGkzB0vh5l/m7R6hGP/9e7aiop8MB+GM/WKr4JvIoWOnJ3Xu12+8Kb2MqANRVNGOJr+sUCDIWcf3cPbliHzaYhBii1iqRrwLHnT69TTB15QFn+R2G75I4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(23010399003)(1800799024)(7416014)(376014)(366016)(22082099003)(10067099003)(18002099003)(11063799006)(261009223027099003)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUdWTjNEWTNJUlh4QW8zMWEwZSt1YWZGK2tqb2NpaDZQZVI1dG1hVEN1dTBR?= =?utf-8?B?VkhFM0FkRlg1RVgxVmpITjVTcWlmMXozUk9hZytIdUExVWtjRkN6cWpFSHgx?= =?utf-8?B?bVd1aW92WE1oS0VqQUpBeU1zVy9tajlYaE85WStVbmlrTlJUVTFGU2tCK3c0?= =?utf-8?B?STZ6cXlaVDlUMGtvYjBKQy81cnBrZ25IRVFqMG95MTIvb3dDaWQ5cFZSaUpq?= =?utf-8?B?YUlaTy9xM0RpaXBTRlNDSHRYeTJsVTZsRUl1S2Z4Y2R4UWh1N3RWRnU5by9N?= =?utf-8?B?Ni9xUkc1MXBMN0NCczc5YVBNN2tLT1YvOXJpS3hpbng2eVVCalhYemJZYldu?= =?utf-8?B?NHJlck1jZEVQTmc1aDNvbGZCeVZtVzQ5YW5zTTQvZ2RiaXh1V1ZIU0dEZ2w5?= =?utf-8?B?K1EwYWhXc0dZd2dMZDFDNjRaSUZGSmtIeWdxU0R3clc0WmtIbG9RenNkeCtl?= =?utf-8?B?NEtwSjRpbEovSnlqZzd0d0dNWXJqK0w0cVZXRVBPcG5OSUI3eXBwOHNtVTBu?= =?utf-8?B?WEJKbGFtSVBNUTBMdnM0Q0QveHEwV3FIV1JmY2MwU3c2cG1PK2JGUnIzUlNF?= =?utf-8?B?SU1xay9FMkJlVWtJMkQyNlNQSkhrWWFTMkVDalJLWlhQdVBQSlppdnhzcDRB?= =?utf-8?B?R0E2MFBVMEJ4YWtBOTlHWE9pR0kxbWI3OGJ0MG1YQmtOMVhLekxWV2x1UTNJ?= =?utf-8?B?bXJlSS9aMllQbks4YWNnL2NCb3kwV3BWajRRcjFVc2l4RGFROVVZK3hPKy9I?= =?utf-8?B?TDVLdnFkSDA1djRhalkwL3ZjMVFuR2JncUsvZ2k1WUlOdCtxVEVCbmZuTWJP?= =?utf-8?B?b1AzQU9aN21oclhsVldLbm5DT2M3UFJDQjI5N0VZTjdJcUlOK2lwQ0g2RWMx?= =?utf-8?B?TElqOS9mRkVwV2pnWXQ3S0JiaWxOcTkrYXVtcXJjcHl6MHczNURvaUV3UXVy?= =?utf-8?B?NVVMVU9mTG4vTWZ2N01nUmpzMmw4ZkRPWTdkZEtyV2NsMUVCU0g0dVBtNzdM?= =?utf-8?B?VDlBbzltOE54TktCYjc2alBSdDBWbFJ0U1Jid2dHNkxJR0Y5UXdIL0VZbVhT?= =?utf-8?B?M3pQbUNQSi9sb3c3ajNnYjVIMSt5eC9senRrc3BCdjc2TXV3dGxiU1NLQjFD?= =?utf-8?B?dFc5Zjk4Z1lBb0RUV3F4eUMzaUhzWkZ1enQzRFFaWFZnZk43aHBXd0pocnh6?= =?utf-8?B?WE9HYmh4M29wbzlXUHRHb2pqclJSZnVrOG82ZURqZ015WHh1enNXbXdOcjUw?= =?utf-8?B?WHcwQkEwV1FyMC90bXlIR1RyQjBCU3ErR2RrckVWeG9aYVZWUWxGSVRkT1dm?= =?utf-8?B?TTd2bXBsSFdENkpCSE1oMXpucjZrZ21XR05jdnRwUE5xZjYxVXNUMktCUldm?= =?utf-8?B?YlZOcUJmbzFoWVhaYjN5ZWRlL244bVRUZzJsdmMrUXZzZ3pyWTJ6MmFrZ2FW?= =?utf-8?B?OFlWYU1qR3dVQmsyOU02b3ZFT05TSDBVdlJmd29DK2dOUUhCdUg1a1dnVE0r?= =?utf-8?B?cm5lUzhjVGFQZEtkVnJtL2ZlaVNseHJLaTJwalUyUzZiYkNSMXlTRDJWY1BX?= =?utf-8?B?OEU3UUpkZWVTTG9JdVJkRVVhK1hsaXFvWUhyZzFlcDhCQVRETWxSbHdSQkFJ?= =?utf-8?B?aEVKRGxzUU5WS2VDUXhWc0xwRUtXaXNIQlJOM0hJRHY5amp5UWJZcFdya2Zv?= =?utf-8?B?VlZYa3NqblcxVzRDVkNmMVRsSkNwQ2srUHEwMHJSRnNYUzVpeWZuVllJdTlD?= =?utf-8?B?S1BMeGJjVkNuc1VMYnQvUDVZc0JMWGFFYUxKZndzN253NDNNM3VDQytlNGZL?= =?utf-8?B?SkQraVFRT2JxT1RybGNNbVdaNVJSZ0IwQ2lZR2RwTG1sdzRtN09tOWUxWGR0?= =?utf-8?B?eUd6Z3dmRDl3VjZOTzBYYjlYRkdsUUZFaVJHVWxuWFVPei9EemZwNy9QVVVs?= =?utf-8?B?ZjYvZVpxUXU2Q1pvUkRQM2xva3o4RjBGZ0Q2M3NNS2psWUt2UkQwU3M1MWs2?= =?utf-8?B?VkR5N0xlU0NrUVkyVEV5TzVRbXh4cDcweVdTdmN4N1kraEJ0VkNFTzNJME14?= =?utf-8?B?VlVuS21QZ3NhSlhvdmlJK1p1Q3lhSE5sWjhUMGdCUWRJTUpZdkVpdzhxbkFL?= =?utf-8?B?VWZ4bk1uWWdHbGVUZWdxbE1RbVhUNTVCMk5td0FITVFtUTZxaWNFWFlzak1l?= =?utf-8?B?cGZtK2NONE4wWmNWSW1oQmlQRkNtU0VYSHdYYVlvNVFLZytMS0xmMXloMVkw?= =?utf-8?B?VDZ6cUY5L2FwRUZYK3lOWnQ0MFBqL3IvNmd3azFpK0dNNno2Y01neUdnZ3ZJ?= =?utf-8?B?bG91d1MySHRyUE5yMTdmaGdKTktVQkxLYkNGZHRlNjUyMVIvOFBVRHdjSUVa?= =?utf-8?Q?6MQiI95UyGLIr+qpNQl6MVDfOZGx7ELR8I4B+?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 598a3d88-ddab-4b60-e871-08df286d7e74 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2026 14:31:25.2403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tN2y4/LcZMYaqh7/KUhVmZWWbHhp1pQullhnRr4j/v5FQUeegjYXQ3w/NyTtxnLZIo1j+aXPsXle2NyemWjaUnHhpPmabvqA4Hkltlr/1GwqC3NlJxR8JWFPegw+Jw2g X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8209 On Mon, Oct 12, 2026 at 06:01:12PM +0800, Peng Fan wrote: > On Mon, Oct 12, 2026 at 12:27:24PM +0300, Andy Shevchenko wrote: > >On Sun, Oct 11, 2026 at 2:54 PM Peng Fan (OSS) wrote: > >> > >> mxc_gpio_generic_config() and mxc_gpio_set_pad_wakeup() call > >> of_device_is_compatible() on every invocation to determine pad wakeup > >> capability and i.MX8QM-specific behavior. These properties are > >> invariant for the lifetime of the device. > >> > >> Extend the hwdata flags scheme introduced in the previous commit with > >> MXC_GPIO_HAS_PAD_WAKEUP and MXC_GPIO_FALL_EDGE_WAKEUP_BROKEN, adding > >> dedicated hwdata instances for imx8qm and imx8qxp (also used by imx8dxl). > >> This replaces the repeated device tree string comparisons in the > >> suspend/resume path with simple flag tests on static per-compatible > >> data. > >> > >> While at it, clean up mxc_gpio_generic_config() to use a local ret > >> variable for clarity instead of the == 0 comparison. > > > >... > > > >> +static struct mxc_gpio_hwdata imx8qm_gpio_hwdata = { > >> + MXC_GPIO_HW_DATA_COMMON, > >> + .flags = MXC_GPIO_FALL_EDGE_WAKEUP_BROKEN | MXC_GPIO_HAS_PAD_WAKEUP, > >> +}; > >> + > >> +static struct mxc_gpio_hwdata imx8qxp_gpio_hwdata = { > >> + MXC_GPIO_HW_DATA_COMMON, > >> + .flags = MXC_GPIO_HAS_PAD_WAKEUP, > >> +}; > > > >Okay, if you want to deduplicate that, make another data structure > >inside hwdata, or wrap hwdata with flags. But really, kill that > >definition. > > Ah. this would need more invasive changes. > > Bartosz, Frank, > > what's your take on this? I think your change is good enough. If need, we can change in future, which only impact one drivers. Frank > > Thanks > Peng > > > > >-- > >With Best Regards, > >Andy Shevchenko > > >