From: Frederic Weisbecker <frederic@kernel.org>
To: Stian Halseth <stian@itx.no>
Cc: Peter Zijlstra <peterz@infradead.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Thomas Gleixner <tglx@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/cputime: Don't warn when the tick period starts after idle exit
Date: Mon, 26 Oct 2026 17:42:39 +0100 [thread overview]
Message-ID: <at-C_3rGi55L1v2X@localhost.localdomain> (raw)
In-Reply-To: <20261025100202.2584654-1-stian@itx.no>
Le Sun, Oct 25, 2026 at 11:02:02AM +0100, Stian Halseth a écrit :
> kcpustat_dyntick_stop() warns if idle ends before the current tick
> period has started. It fired once during boot on a Dell XPS 13, in
> CPU 0's first idle period, right after the switch from refined-jiffies
> to tsc-early.
>
> That can happen. The clocksource switch continues ktime from the last
> jiffies update, so ktime falls behind the tick by up to a tick, and the
> sched timer that NOHZ arms next on tick_next_period can expire more
> than a tick after now. In a KVM guest it was 1.5 ticks ahead after a
> switch from jiffies to hpet. An idle period that stops the tick and
> exits before it fires then sees ts->last_tick - TICK_NSEC after now.
I'm a bit confused by the scenario that happens here. Do you mean that
after switching from a clocksource to another, ktime_get() goes backward?
Also refine-jiffies is not a suitable clocksource for nohz, so last_tick
shouldn't be updated while refine-jiffies is the clocksource.
What am I missing?
Thanks.
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-10-26 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 14:29 [PATCH v3] sched/cputime: Don't account idle time twice after dyntick-idle Stian Halseth
2026-10-14 12:17 ` Frederic Weisbecker
2026-10-16 8:01 ` [tip: sched/core] " tip-bot2 for Stian Halseth
2026-10-25 7:27 ` WARNING: kernel/sched/cputime.c:481 at kcpustat_dyntick_stop+0x8b/0xa0, CPU#0: swapper/0/0 (was: [PATCH v3] sched/cputime: Don't account idle time twice after dyntick-idle) Paul Menzel
2026-10-25 8:13 ` Stian Halseth
2026-10-25 10:02 ` [PATCH] sched/cputime: Don't warn when the tick period starts after idle exit Stian Halseth
2026-10-26 16:42 ` Frederic Weisbecker [this message]
2026-10-26 17:28 ` Stian Halseth
2026-10-27 17:06 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at-C_3rGi55L1v2X@localhost.localdomain \
--to=frederic@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@lists.linux.dev \
--cc=sshegde@linux.ibm.com \
--cc=stian@itx.no \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®