mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	David Dai <david.dai@linux.dev>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET sched_ext/for-7.5] sched_ext: Sync tools headers with scx and fix unsigned enum reads
Date: Sun, 25 Oct 2026 11:21:51 +0100	[thread overview]
Message-ID: <at3YP-bVKwyfVKBT@gpd4> (raw)
In-Reply-To: <20261023232102.1124938-1-tj@kernel.org>

Hi Tejun,

On Fri, Oct 23, 2026 at 01:20:58PM -1000, Tejun Heo wrote:
> Hello,
> 
> This patchset fixes __COMPAT_read_enum() sign-extending unsigned 4-byte
> enums, which made SCX_RESCUE_DISABLE read as 0xffffffffffffffff, syncs the
> shared headers in tools/sched_ext/include with the scx repo, and drops the
> enum lookup table entries for enumerators the kernel no longer has. The scx
> side is https://github.com/sched-ext/scx/pull/3930, merged, and
> https://github.com/sched-ext/scx/pull/3932.
> 
> With both applied, the shared headers in tools/sched_ext/include are
> identical to scx's except the two generated tables, enum_defs.autogen.h and
> enums_abi.autogen.h, which each side regenerates from its own vmlinux.h.
> 
> Based on sched_ext/for-7.5 (dd3b1d9be27c).
> 
> This patchset contains the following 4 patches.
> 
>  0001 sched_ext: Don't sign-extend unsigned enums in __COMPAT_read_enum()
>  0002 sched_ext: Sync tools autogen enum lookup tables from the scx repo
>  0003 sched_ext: Sync common and compat headers from the scx repo
>  0004 sched_ext: Drop stale entries from the enum lookup tables

Left a comment (nit) on 1/4. For 2-4:

Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks,
-Andrea

      parent reply	other threads:[~2026-10-25 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 23:20 Tejun Heo
2026-10-23 23:20 ` [PATCH 1/4] sched_ext: Don't sign-extend unsigned enums in __COMPAT_read_enum() Tejun Heo
2026-10-25 10:20   ` Andrea Righi
2026-10-23 23:21 ` [PATCH 2/4] sched_ext: Sync tools autogen enum lookup tables from the scx repo Tejun Heo
2026-10-23 23:21 ` [PATCH 3/4] sched_ext: Sync common and compat headers " Tejun Heo
2026-10-23 23:21 ` [PATCH 4/4] sched_ext: Drop stale entries from the enum lookup tables Tejun Heo
2026-10-25 10:21 ` Andrea Righi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at3YP-bVKwyfVKBT@gpd4 \
    --to=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=david.dai@linux.dev \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®