From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: himanshu bakshi <himanshu.bakshi478@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Fix line length warning
Date: Sun, 25 Oct 2026 17:01:30 +0200 [thread overview]
Message-ID: <at4Zyt9QP3Yo-ZTC@ashevche-desk.local> (raw)
In-Reply-To: <20261024180803.108872-1-himanshu.bakshi478@gmail.com>
On Sat, Oct 24, 2026 at 11:38:03PM +0530, himanshu bakshi wrote:
>
> Split the line in fbtft_init_dbg macro to keep it within the limit of 100
> columns and address the check-patch warning.
checkpatch
(in one word)
...
> #define fbtft_init_dbg(dev, format, arg...) \
> do { \
> if (unlikely((dev)->platform_data && \
> - (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
> + (((struct fbtft_platform_data *)(dev)->platform_data)-> \
> + display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
> dev_info(dev, format, ##arg); \
> } while (0)
First of all, make sure that \ (backslashes) occupy the same column on each
line of this macro. Next one, it's better to add a temporary variable to
hold the platform data pointer. Something like
struct fbtft_platform_data *__pd = dev_get_platdata(dev); \
\
if (unlikely(pd && pd->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS) \
dev_info(dev, format, ##arg); \
And last, but not least, have you checked with `git grep` how it's being used?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-25 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 18:08 himanshu bakshi
2026-10-25 15:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at4Zyt9QP3Yo-ZTC@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshu.bakshi478@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®