From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.35 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792976215; b=3RR+O0hMvhOTjBML22Sy1CQ4Ev4iaQuXj1ghM/z/ESTtwyoisquejlJ9BInRIH/z9VJY tZvqHdTSiBy8D9qetXt2dDeiARPud2pvb7sSDwk9u1/NYX1P6ViZj2GjaAuj7J3gfhBRa yY8wgqkT3FZ64u+MMdjbZhGcHQZtjXsd86oWzl4YFE32rzb9zqHexFDJxpcGxBS9qYMv8 ofC/mQsTj/cvINB/FzNv/SKimBVTXfhMvRFjDPpAaeNHmhqhVL0NCcVodQ2GIiMmYlzo8 gFCHqpxlM9d2HT+YjsbojxL3mlcGAi4pgFMbQTh1OsmWq4DlXnlaVidXwpV3PAezZBw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792976215; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=RLx2Ro+oXYG6Esl8h8Oz8vJrCiQY2x6fL9DTdSUob0M=; b=ciFG+W7rY2hO7mQabXXvN5PD8kB5B9Args6KPesAbAwRCY643x8ehRnvoNbm4203Vr1l n8qQWQbmXofEbsNZFLtggkDspOtCT7DYCT5IiftkMc9cexZAAayprK70pbghDGYl1/HYr IcztHO5cRQg5Y6pOoAeo/f5Hi+jU30/+uAVeIzbsHo8PB8Y6m09MyVDfkYwmI0gWvEVmk ZJP7OqT8rrhXItAMKMZb7dTW6aa4kLDuZVpl653cObMzVBREaWmExkgr87Fije2UECD+U eKANEXRefMd37lfCIuPpH1SJskiUAq7jmMtCQLAwHfrUa9tb1pG6Ix1L/k95Au7Ujxg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=D3HVgW8u; arc=none smtp.remote-ip=91.218.175.35 Received: from mta0.migadu.com (out-35.mta0.migadu.com [91.218.175.35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BF17606A31B for ; Mon, 26 Oct 2026 00:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5BF17606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=D3HVgW8u X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=DhZfvcVUIAIZszQSJBwAYpMOK0X26Pzmzgl/OqwUSZI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792976212; v=1; x=1793581012; b=D3HVgW8u+Is1mGe+u+pOX/SkrZtonVjGkXjBIqj0GBsj+Rc8JDSpV3aWyYoVKQdhzmmU1+wm 8r0ZVJ801W+QlSPfzu9ykiPFe7+evZWPLIcrsiCL4fXZHzHQN9fAE2VZrVh0Takx0cAQMGu14fd VAmXyfHnCnUf+9evqXJvr2zw= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 0f3592458cc6a98b; Mon, 26 Oct 2026 00:56:52 +0000 X-Mizu-Trace-ID: 0f3592458cc6a98b X-Migadu-Flow: FLOW_OUT Date: Mon, 26 Oct 2026 08:56:44 +0800 From: Hangbin Liu To: Timur Stukan Cc: netdev@vger.kernel.org, Hangbin Liu , Fernando Fernandez Mancera , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Nikolay Aleksandrov , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] bonding: fix missing down path on speed/duplex failure after FAIL->UP Message-ID: References: <20261022103821.89552-1-timur.stukan.linux@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Oct 23, 2026 at 03:35:57PM +0300, Timur Stukan wrote: > On Fri, 23 Oct 2026 at 10:48, Hangbin Liu wrote: > > > > static void bond_miimon_commit(struct bonding *bond) > > > { > > > struct slave *slave, *primary, *active; > > > @@ -2807,10 +2828,21 @@ static void bond_miimon_commit(struct bonding *bond) > > > err = bond_update_speed_duplex(slave); > > > netdev_unlock_ops(slave->dev); > > > if (err && bond_needs_speed_duplex(bond)) { > > > - slave->link = BOND_LINK_DOWN; > > > > Hmm, this issue only happens when link_state is on > > > > netif_running(slave->dev) && netif_carrier_ok(slave->dev); > > > > while !netif_device_present. Should we set the link up when device detached? > > > Hi Hangbin, > > Thanks for the review and the suggestion. > > A detached device is one way to get there, but it does not cover all > the ways to hit this bug. In particular, it does not cover the case i > reproduced: during inspect both link_state and netif_device_present() > are true, but the carrier is lost after inspect and before commit, so > reading speed/duplex fails in commit. Hi Timur, Thanks for the explain, but the same question to this patch. How do you make sure the carrier is not lost during bond_miimon_inspect() and this slave->link_prev_state setting? Thanks Hangbin