mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Jérémy Jean" <Jeremy.Jean@oss.cyber.gouv.fr>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
	"Pankaj Gupta" <pankaj.gupta@nxp.com>,
	"Sahil Malhotra" <sahil.malhotra@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [REPOST PATCH] crypto: caam - reject overlong RSA CRT parameters
Date: Mon, 26 Oct 2026 12:42:46 +0800	[thread overview]
Message-ID: <at7aRrDPsroWZtuA@gondor.apana.org.au> (raw)
In-Reply-To: <atCc0iL0RrDLwHHX@gondor.apana.org.au>

On Thu, Oct 15, 2026 at 08:28:50PM +1100, Herbert Xu wrote:
> On Thu, Oct 08, 2026 at 09:35:53AM +0000, Jérémy Jean wrote:
> > caam_read_rsa_crt() right-aligns dP, dQ, and qInv in buffers sized
> > from the corresponding prime. rsa_parse_priv_key() only bounds these
> > integers against n, so a malformed key can provide, for example, a
> > two-byte dP with a one-byte p. dstlen - nbytes then underflows and
> > memcpy() writes outside the allocation during set_priv_key(). KASAN
> > reports a slab-out-of-bounds write in caam_read_rsa_crt().
> > 
> > Reject empty or overlong CRT parameters after stripping leading zeros.
> > qInv is consumed by CAAM as a p-sized value, so size it from p rather
> > than q to match the DMA mapping in set_rsa_priv_f3_pdb(). Let the
> > top-level key cleanup handle partial form-3 allocations and return the
> > specific error to the caller.
> > 
> > Also test nbytes before dereferencing it while stripping zeros, so an
> > all-zero integer does not read one byte beyond its input.
> > 
> > Fixes: 4a651b122adb ("crypto: caam - add support for RSA key form 3")
> > Cc: stable@vger.kernel.org
> > Assisted-by: LLM
> > Signed-off-by: Jérémy Jean <Jeremy.Jean@oss.cyber.gouv.fr>
> > ---
> >  drivers/crypto/caam/caampkc.c | 69 +++++++++++++++--------------------
> >  1 file changed, 30 insertions(+), 39 deletions(-)
> 
> Sahil, could you please review this patch?

Hi Sahil:

It's been two weeks and you've provided no feedback.

If there isn't going to be timely feedback to patches on this
driver then it will be removed.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2026-10-26  4:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  9:35 Jérémy Jean
2026-10-15  9:28 ` Herbert Xu
2026-10-26  4:42   ` Herbert Xu [this message]
2026-10-26 11:42     ` [EXT] " Sahil Malhotra (OSS)
2026-10-26 11:41 ` [EXT] " Sahil Malhotra (OSS)
2026-11-04  9:04 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at7aRrDPsroWZtuA@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=Jeremy.Jean@oss.cyber.gouv.fr \
    --cc=davem@davemloft.net \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.gupta@nxp.com \
    --cc=sahil.malhotra@nxp.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®