From: Dan Carpenter <error27@gmail.com>
To: Anghel Mihai-Alexandru <mih@ianghel.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager_module: add missing newline to sysfs_emit()
Date: Mon, 26 Oct 2026 08:49:48 +0300 [thread overview]
Message-ID: <at7p_FWu_3leali5@stanley.mountain> (raw)
In-Reply-To: <20261025205427.259512-1-mih@ianghel.com>
On Sun, Oct 25, 2026 at 10:54:27PM +0200, Anghel Mihai-Alexandru wrote:
> Documentation/filesystems/sysfs.rst recommends that single-value sysfs
> attributes end with a newline, consistent with other Greybus sysfs
> show() callbacks (see e.g. loopback.c). The name/vid/pid/intf_id/
> ip_devices/op_devices attributes were missing it.
>
> No functional change.
It absolutely is a functional change and that's why we have rejected
it a dozen times already. :P
regards,
dan carpenter
prev parent reply other threads:[~2026-10-26 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 20:54 Anghel Mihai-Alexandru
2026-10-26 5:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at7p_FWu_3leali5@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=mih@ianghel.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®