From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Simon Kruse <simon0x+git@proton.me>
Cc: Daniel Scally <dan.scally@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5693: Support control events
Date: Mon, 26 Oct 2026 13:43:52 +0200 [thread overview]
Message-ID: <at88-MnXMFopRLl-@kekkonen.localdomain> (raw)
In-Reply-To: <20261010142042.23253-1-simon0x+git@proton.me>
Hi Simon,
On Sat, Oct 10, 2026 at 02:20:54PM +0000, Simon Kruse wrote:
> The sensor subdev exposes controls but does not implement the control
> event operations, so VIDIOC_SUBSCRIBE_EVENT fails and v4l2-compliance
> reports:
>
> fail: v4l2-test-controls.cpp(1128): subscribe event for control 'User Controls' failed
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
>
> Add the standard control event subdev operations and set
> V4L2_SUBDEV_FL_HAS_EVENTS.
>
> Signed-off-by: Simon Kruse <simon0x+git@proton.me>
Could you instead move the driver to use sub-device state? See an example
in commit e8a5b1df000e1a23c04dadbe99621441e0889f88 . You'll get control
events as a bonus. :-)
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2026-10-26 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 14:20 Simon Kruse
2026-10-25 15:43 ` Fernando Rimoli
2026-10-26 11:43 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at88-MnXMFopRLl-@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=simon0x+git@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®