From: Sakari Ailus <sakari.ailus@iki.fi>
To: Denis Benato <denis.benato@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Luke D . Jones" <luke@ljones.dev>,
"Mateusz Schyboll" <dragonn@op.pl>,
"Denis Benato" <benato.denis96@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 2/2] hid: asus: always fully initialize devices
Date: Mon, 26 Oct 2026 11:55:41 +0200 [thread overview]
Message-ID: <at8jnW4RaMPJItUK@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20260216175539.12415-2-denis.benato@linux.dev>
Hi Benato,
On Mon, Feb 16, 2026 at 06:55:39PM +0100, Denis Benato wrote:
> ASUS has more devices other than laptop keyboards which needs
> to be initializated: the init sequence is the same as keyboards.
>
> ID1 and ID2 are USB report IDs that are correctly enumerated:
> send init commands to all devices that supports those reports IDs.
>
> Signed-off-by: Denis Benato <denis.benato@linux.dev>
This patch appears to break input devices on Asus T100TA. With the patch
applied, I'm getting a steady flow of:
[ 256.358075] usb 1-3: USB disconnect, device number 120
[ 257.034324] usb 1-3: new full-speed USB device number 121 using xhci_hcd
[ 257.175003] usb 1-3: New USB device found, idVendor=0b05, idProduct=17e0, bcdDevice= 2.49
[ 257.175050] usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 257.175073] usb 1-3: Product: ASUS Base Station(T100)
[ 257.175091] usb 1-3: Manufacturer: ASUSTek COMPUTER INC.
[ 257.180978] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:0B05:17E0.02DB/input/input749
[ 257.266585] asus 0003:0B05:17E0.02DB: input,hidraw1: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
[ 257.270711] asus 0003:0B05:17E0.02DC: Fixing up Asus T100 keyb report descriptor
[ 257.272302] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.1/0003:0B05:17E0.02DC/input/input750
[ 257.327059] asus 0003:0B05:17E0.02DC: input,hiddev0,hidraw2: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
[ 257.332642] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.2/0003:0B05:17E0.02DD/input/input751
[ 257.334115] asus 0003:0B05:17E0.02DD: input,hiddev1,hidraw3: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
[ 257.336098] asus 0003:0B05:17E0.02DD: Asus handshake 5d failed to send: -71
[ 257.336263] asus 0003:0B05:17E0.02DD: Failed to initialize 0x5d: -71.
[ 257.336605] asus 0003:0B05:17E0.02DD: Asus failed to start multitouch: -71
[ 257.367022] asus 0003:0B05:17E0.02DD: probe with driver asus failed with error -71
[ 257.367917] usb 1-3: USB disconnect, device number 121
I haven't tried to debug this yet so just FYI.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-10-26 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 17:55 [PATCH 1/2] hid: asus: add xg mobile 2023 external hardware support Denis Benato
2026-02-16 17:55 ` [PATCH 2/2] hid: asus: always fully initialize devices Denis Benato
2026-02-27 13:11 ` Jiri Kosina
2026-10-26 9:55 ` Sakari Ailus [this message]
2026-10-26 10:00 ` Denis Benato
2026-10-26 11:32 ` Sakari Ailus
2026-10-26 11:46 ` Denis Benato
2026-02-27 13:11 ` [PATCH 1/2] hid: asus: add xg mobile 2023 external hardware support Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at8jnW4RaMPJItUK@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=benato.denis96@gmail.com \
--cc=bentiss@kernel.org \
--cc=denis.benato@linux.dev \
--cc=dragonn@op.pl \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®