From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: sx9310: report a hysteresis of 0 when it is disabled
Date: Mon, 26 Oct 2026 12:41:53 +0200 [thread overview]
Message-ID: <at8ucTXC_VYqdVON@ashevche-desk.local> (raw)
In-Reply-To: <20261026100041.16018-1-kapoorarnav43@gmail.com>
On Mon, Oct 26, 2026 at 03:30:32PM +0530, Arnav Kapoor wrote:
> sx9310_read_hysteresis() turns a PROXHYST value of 0 (no hysteresis)
> into a shift of 0 and reports the full threshold, which writing back
> then usually fails with -EINVAL. Report 0, as sx9324 and sx9360 do.
...
> regval = FIELD_GET(SX9310_REG_PROX_CTRL10_HYST_MASK, regval);
> if (!regval)
> - regval = 5;
> -
> - /* regval is at most 5 */
> - *val = pthresh >> (5 - regval);
> + *val = 0;
> + else
> + *val = pthresh >> (5 - regval);
While at it, invert the conditional.
if (regval)
*val = pthresh >> (5 - regval);
else
*val = 0;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-26 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 10:00 Arnav Kapoor
2026-10-26 10:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at8ucTXC_VYqdVON@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®