mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Ido Schimmel <idosch@nvidia.com>,
	David Ahern <dsahern@kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Simon Horman <horms@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	 Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	 Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	 Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>,
	 Emil Tsalapatis <emil@etsalapatis.com>,
	Ihor Solodrai <ihor.solodrai@linux.dev>,
	 John Fastabend <john.fastabend@gmail.com>,
	Stanislav Fomichev <sdf@fomichev.me>,
	 Shuah Khan <shuah@kernel.org>,
	Eric Dumazet <edumazet@kernel.org>,
	netdev@vger.kernel.org,  linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 david.laight.linux@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH net-next v3 0/7] ipv4,ipv6: convert the getsockopt switches to sockopt_t
Date: Mon, 26 Oct 2026 03:49:17 -0700	[thread overview]
Message-ID: <at8v8Orx3je4KD2i@gmail.com> (raw)
In-Reply-To: <7ceef2dc-717c-44f5-9974-1ed8f0440fa3@redhat.com>

On Tue, Oct 20, 2026 at 04:05:39PM +0200, Paolo Abeni wrote:
> On 10/19/26 10:19, Ido Schimmel wrote:
> > On Thu, Oct 15, 2026 at 03:05:29AM -0700, Breno Leitao wrote:
> > > This series continues the migration to sockopt_t, as described in [1].
> > > do_ip_getsockopt() and do_ipv6_getsockopt() still take a sockptr_t pair,
> > > and everything they forward to now takes a sockopt_t, so convert them
> > > both.
> > 
> > Acked-by: Ido Schimmel <idosch@nvidia.com>
> > 
> > Given the user visible changes, the fact that the merge window is now
> > open and that this isn't the last part of the conversion, my preference
> > would be for this to be re-posted after the merge window.
> 
> I agree on the above, also clashiko noted that patch 7 lacks an additional
> 
> CONFIG_IP_MULTICAST=y

Ack! I will add CONFIG_IP_MULTICAST to patch 7 and submit once the merge
window is closed and net-next is re-opened.

Thanks,
--breno

      reply	other threads:[~2026-10-26 10:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 10:05 Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 1/7] ipv6: treat a negative optlen as 4 in do_ipv6_getsockopt() Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 2/7] net: cap sockopt_expand_out() at MAX_RW_COUNT Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 3/7] ipv6: mcast: convert ip6_mc_msfget() to sockopt_t Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 4/7] ipv4: igmp: convert ip_mc_gsfget() " Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 5/7] ipv4: convert do_ip_getsockopt() " Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 6/7] ipv6: convert do_ipv6_getsockopt() " Breno Leitao
2026-10-15 10:05 ` [PATCH net-next v3 7/7] selftests: net: getsockopt_iter: cover ip and ipv6 Breno Leitao
2026-10-19  8:19 ` [PATCH net-next v3 0/7] ipv4,ipv6: convert the getsockopt switches to sockopt_t Ido Schimmel
2026-10-20 13:59   ` Paolo Abeni
2026-10-20 14:05   ` Paolo Abeni
2026-10-26 10:49     ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at8v8Orx3je4KD2i@gmail.com \
    --to=leitao@debian.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david.laight.linux@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=emil@etsalapatis.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®